Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/child/child_thread_impl.h

Issue 2107143003: Revert of Make RenderProcessHost/RenderThread use MojoChildConnection/MojoShellConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rph2
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/child_thread_impl.h
diff --git a/content/child/child_thread_impl.h b/content/child/child_thread_impl.h
index a59ca84b6d99a3561b6d1533a1ad6a3d56127346..1ca22473af0e79fe55861880ed6af5aa256e4c8f 100644
--- a/content/child/child_thread_impl.h
+++ b/content/child/child_thread_impl.h
@@ -24,7 +24,6 @@
#include "ipc/ipc_message.h" // For IPC_MESSAGE_LOG_ENABLED.
#include "ipc/ipc_platform_file.h"
#include "ipc/message_router.h"
-#include "services/shell/public/cpp/shell_client.h"
namespace base {
class MessageLoop;
@@ -69,8 +68,7 @@
// The main thread of a child process derives from this class.
class CONTENT_EXPORT ChildThreadImpl
: public IPC::Listener,
- virtual public ChildThread,
- public NON_EXPORTED_BASE(shell::ShellClient){
+ virtual public ChildThread {
public:
struct CONTENT_EXPORT Options;
@@ -98,13 +96,8 @@
#endif
void RecordAction(const base::UserMetricsAction& action) override;
void RecordComputedAction(const std::string& action) override;
- MojoShellConnection* GetMojoShellConnection() override;
shell::InterfaceRegistry* GetInterfaceRegistry() override;
shell::InterfaceProvider* GetRemoteInterfaces() override;
-
- // shell::ShellClient:
- shell::InterfaceRegistry* GetInterfaceRegistryForConnection() override;
- shell::InterfaceProvider* GetInterfaceProviderForConnection() override;
IPC::SyncChannel* channel() { return channel_.get(); }
@@ -254,11 +247,7 @@
void EnsureConnected();
std::unique_ptr<mojo::edk::ScopedIPCSupport> mojo_ipc_support_;
- bool use_mojo_shell_connection_ = false;
std::unique_ptr<MojoApplication> mojo_application_;
- std::unique_ptr<MojoShellConnection> mojo_shell_connection_;
- std::unique_ptr<shell::InterfaceRegistry> interface_registry_;
- std::unique_ptr<shell::InterfaceProvider> remote_interfaces_;
std::string channel_name_;
std::unique_ptr<IPC::SyncChannel> channel_;
@@ -329,7 +318,6 @@
std::vector<IPC::MessageFilter*> startup_filters;
std::string in_process_ipc_token;
std::string in_process_application_token;
- bool use_mojo_shell_connection = false;
private:
Options();
@@ -343,7 +331,6 @@
Builder& UseMojoChannel(bool use_mojo_channel);
Builder& WithChannelName(const std::string& channel_name);
Builder& AddStartupFilter(IPC::MessageFilter* filter);
- Builder& UseMojoShellConnection(bool use_mojo_shell_connection);
Options Build();
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698