src/IceTargetLoweringX86Base.h - Issue 2107073002: Subzero: Merge SpillVariable functionality directly into Variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86Base.h

Issue 2107073002: Subzero: Merge SpillVariable functionality directly into Variable. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86Base.h

diff --git a/src/IceTargetLoweringX86Base.h b/src/IceTargetLoweringX86Base.h

index d465423b95796cf14a7134560cdccd4131a6fa48..b1b2b82ccc640dc79a5c8af3da53279a746d56bb 100644

--- a/src/IceTargetLoweringX86Base.h

+++ b/src/IceTargetLoweringX86Base.h

@@ -70,7 +70,6 @@ public:

using X86Operand = typename Traits::X86Operand;

using X86OperandMem = typename Traits::X86OperandMem;

using SegmentRegisters = typename Traits::X86OperandMem::SegmentRegisters;

- using SpillVariable = typename Traits::SpillVariable;

using InstX86Br = typename Traits::Insts::Br;

using InstX86FakeRMW = typename Traits::Insts::FakeRMW;

« no previous file with comments | « src/IceTargetLoweringX8664Traits.h ('k') | src/IceTargetLoweringX86BaseImpl.h » ('j') | no next file with comments »