Web Animations: Sort Animations in the AnimationStack

Web Animations: Sort Animations in the AnimationStack

This patch sorts animations in the stack so that they will be applied in the
correct order. Note that due to the way compositor integration currently is
implemented, we don't know the exact time when new animations will be started,
but expect it will be very close to the current timeline time.

http://dev.w3.org/fxtf/web-animations/#the-animation-stack

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170257

[alancutter (OOO until 2018), 2014-03-26 00:43:17]

lgtm

[alancutter (OOO until 2018), 2014-03-26 01:23:02]

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimationStack.cpp (right):

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationStack.cpp:33: #include
"core/animation/Interpolation.h"
Not sure why style never picked up on this but this Interpolation.h include
should be one line lower.

[dstockwell, 2014-03-26 01:32:21]

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimationStack.cpp (right):

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationStack.cpp:88: // We don't exactly know when new
animations will start, but timelineCurrentTime is a good estimate.
We should probably track the start time for the purpose of sorting separately
from the start time for the purpose of timing calculations. This would allow us
to use the time at which the player was first constructed for sorting compositor
animations.

[Timothy Loh, 2014-03-26 03:00:42]

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimationStack.cpp (right):

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationStack.cpp:33: #include
"core/animation/Interpolation.h"
On 2014/03/26 01:23:03, alancutter wrote:
> Not sure why style never picked up on this but this Interpolation.h include
> should be one line lower.

Done.

https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationStack.cpp:88: // We don't exactly know when new
animations will start, but timelineCurrentTime is a good estimate.
On 2014/03/26 01:32:21, dstockwell wrote:
> We should probably track the start time for the purpose of sorting separately
> from the start time for the purpose of timing calculations. This would allow
us
> to use the time at which the player was first constructed for sorting
compositor
> animations.

Done.

[dstockwell, 2014-03-26 04:28:18]

On 2014/03/26 03:00:42, Timothy Loh wrote:
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> File Source/core/animation/AnimationStack.cpp (right):
> 
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> Source/core/animation/AnimationStack.cpp:33: #include
> "core/animation/Interpolation.h"
> On 2014/03/26 01:23:03, alancutter wrote:
> > Not sure why style never picked up on this but this Interpolation.h include
> > should be one line lower.
> 
> Done.
> 
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> Source/core/animation/AnimationStack.cpp:88: // We don't exactly know when new
> animations will start, but timelineCurrentTime is a good estimate.
> On 2014/03/26 01:32:21, dstockwell wrote:
> > We should probably track the start time for the purpose of sorting
separately
> > from the start time for the purpose of timing calculations. This would allow
> us
> > to use the time at which the player was first constructed for sorting
> compositor
> > animations.
> 
> Done.

Can we do the latter part too (fill out the value in
Timeline::createAnimationPlayer) ? I think that would allow us to avoid passing
the current time into calculateActive*

[Timothy Loh, 2014-03-26 06:26:06]

On 2014/03/26 04:28:18, dstockwell wrote:
> On 2014/03/26 03:00:42, Timothy Loh wrote:
> >
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> > File Source/core/animation/AnimationStack.cpp (right):
> > 
> >
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> > Source/core/animation/AnimationStack.cpp:33: #include
> > "core/animation/Interpolation.h"
> > On 2014/03/26 01:23:03, alancutter wrote:
> > > Not sure why style never picked up on this but this Interpolation.h
include
> > > should be one line lower.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> > Source/core/animation/AnimationStack.cpp:88: // We don't exactly know when
new
> > animations will start, but timelineCurrentTime is a good estimate.
> > On 2014/03/26 01:32:21, dstockwell wrote:
> > > We should probably track the start time for the purpose of sorting
> separately
> > > from the start time for the purpose of timing calculations. This would
allow
> > us
> > > to use the time at which the player was first constructed for sorting
> > compositor
> > > animations.
> > 
> > Done.
> 
> Can we do the latter part too (fill out the value in
> Timeline::createAnimationPlayer) ? I think that would allow us to avoid
passing
> the current time into calculateActive*

This doesn't work because we need the time for InertAnimations. I'll leave the
SortInfo in for now since we'll need it in a later patch.

[dstockwell, 2014-03-27 12:19:40]

On 2014/03/26 06:26:06, Timothy Loh wrote:
> On 2014/03/26 04:28:18, dstockwell wrote:
> > On 2014/03/26 03:00:42, Timothy Loh wrote:
> > >
> >
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> > > File Source/core/animation/AnimationStack.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> > > Source/core/animation/AnimationStack.cpp:33: #include
> > > "core/animation/Interpolation.h"
> > > On 2014/03/26 01:23:03, alancutter wrote:
> > > > Not sure why style never picked up on this but this Interpolation.h
> include
> > > > should be one line lower.
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/210703002/diff/1/Source/core/animation/Animat...
> > > Source/core/animation/AnimationStack.cpp:88: // We don't exactly know when
> new
> > > animations will start, but timelineCurrentTime is a good estimate.
> > > On 2014/03/26 01:32:21, dstockwell wrote:
> > > > We should probably track the start time for the purpose of sorting
> > separately
> > > > from the start time for the purpose of timing calculations. This would
> allow
> > > us
> > > > to use the time at which the player was first constructed for sorting
> > > compositor
> > > > animations.
> > > 
> > > Done.
> > 
> > Can we do the latter part too (fill out the value in
> > Timeline::createAnimationPlayer) ? I think that would allow us to avoid
> passing
> > the current time into calculateActive*
> 
> This doesn't work because we need the time for InertAnimations. I'll leave the
> SortInfo in for now since we'll need it in a later patch.

OK, but we can at least set the sort time in createAnimationPlayer, otherwise
wont we be using NaN on any subsequent frames before a start time is set?

[Timothy Loh, 2014-03-28 00:29:25]

On 2014/03/27 12:19:40, dstockwell wrote:
> OK, but we can at least set the sort time in createAnimationPlayer, otherwise
> wont we be using NaN on any subsequent frames before a start time is set?

Setting it in the ctor now.

[dstockwell, 2014-03-28 01:08:02]

lgtm

[commit-bot: I haz the power, 2014-03-28 01:08:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/210703002/200001

[commit-bot: I haz the power, 2014-03-28 01:16:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:16:37]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[Timothy Loh, 2014-03-28 01:56:27]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:56:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/210703002/220001

[commit-bot: I haz the power, 2014-03-28 02:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:11:55]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg
  tryserver.blink on mac_blink_compile_dbg

[Timothy Loh, 2014-03-28 02:21:48]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:21:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/210703002/240001

[commit-bot: I haz the power, 2014-03-28 02:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:33:00]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[Timothy Loh, 2014-03-28 02:34:00]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:34:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/210703002/240001

[commit-bot: I haz the power, 2014-03-28 02:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:38:34]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[Timothy Loh, 2014-03-28 02:39:05]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:39:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/210703002/240001

[commit-bot: I haz the power, 2014-03-28 03:29:43]

Change committed as 170257