ui/views/accessibility/native_view_accessibility.cc - Issue 2106953005: Mac: Add new accessibility attributes for textfields (and some for all views).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/native_view_accessibility.cc

Issue 2106953005: Mac: Add new accessibility attributes for textfields (and some for all views). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ax-attrs

Patch Set: Typo. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/accessibility/platform/ax_platform_node_mac.mm ('K') | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/accessibility/native_view_accessibility.cc

diff --git a/ui/views/accessibility/native_view_accessibility.cc b/ui/views/accessibility/native_view_accessibility.cc

index ab86be128e34ba269b12e339be1725abae1e4016..c9c4cd0a1952f377efb26c1cc2f1e4761c0d6322 100644

--- a/ui/views/accessibility/native_view_accessibility.cc

+++ b/ui/views/accessibility/native_view_accessibility.cc

@@ -63,10 +63,14 @@ const ui::AXNodeData& NativeViewAccessibility::GetData() {

base::UTF16ToUTF8(state.default_action));

data_.AddStringAttribute(ui::AX_ATTR_SHORTCUT,

base::UTF16ToUTF8(state.keyboard_shortcut));

+ data_.AddStringAttribute(ui::AX_ATTR_PLACEHOLDER,

+ base::UTF16ToUTF8(state.placeholder));

data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, state.selection_start);

data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, state.selection_end);

data_.state |= (1 << ui::AX_STATE_FOCUSABLE);

+ if (view_->HasFocus())

dmazzoni 2016/06/29 16:24:11 You shouldn't need this. Use NativeViewAccessibili

Patti Lor 2016/06/30 05:29:54 Done.

+ data_.state |= (1 << ui::AX_STATE_FOCUSED);

if (!view_->enabled())

data_.state |= (1 << ui::AX_STATE_DISABLED);