Mac: Add new accessibility attributes for textfields (and some for all views).

ui/views/accessibility/native_view_accessibility.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event_utils.h"
@@ skipping 45 matching lines @@
   data_ = ui::AXNodeData();
   data_.role = state.role;
   data_.state = state.state();
   data_.location = view_->GetBoundsInScreen();
   data_.AddStringAttribute(ui::AX_ATTR_NAME, base::UTF16ToUTF8(state.name));
   data_.AddStringAttribute(ui::AX_ATTR_VALUE, base::UTF16ToUTF8(state.value));
   data_.AddStringAttribute(ui::AX_ATTR_ACTION,
                            base::UTF16ToUTF8(state.default_action));
   data_.AddStringAttribute(ui::AX_ATTR_SHORTCUT,
                            base::UTF16ToUTF8(state.keyboard_shortcut));
+  data_.AddStringAttribute(ui::AX_ATTR_PLACEHOLDER,
+                           base::UTF16ToUTF8(state.placeholder));
   data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, state.selection_start);
   data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, state.selection_end);
 
   data_.state |= (1 << ui::AX_STATE_FOCUSABLE);
+  if (view_->HasFocus())

[dmazzoni, 2016/06/29 16:24:11]

You shouldn't need this. Use NativeViewAccessibility::GetFocus() instead, which
returns a single object that's focused

[Patti Lor, 2016/06/30 05:29:54]

Done.

+    data_.state |= (1 << ui::AX_STATE_FOCUSED);
 
   if (!view_->enabled())
     data_.state |= (1 << ui::AX_STATE_DISABLED);
 
   if (!view_->visible())
     data_.state |= (1 << ui::AX_STATE_INVISIBLE);
 
   return data_;
 }
 
@@ skipping 163 matching lines @@
               child_widget_platform_node->GetDelegate());
       if (child_widget_view_accessibility->parent_widget() != widget)
         child_widget_view_accessibility->SetParentWidget(widget);
     }
 
     result_child_widgets->push_back(child_widget);
   }
 }
 
 }  // namespace views