Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2106933002:
gpu, cmaa: bottom to top is always y-direction. (Closed)
Descriptiongpu, cmaa: bottom to top is always y-direction.
Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case.
It causes lots of difficulty to read the code. Make it consistent.
BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/2d46d1e224b05b216700efff90d4e7374b958d2d
Cr-Commit-Position: refs/heads/master@{#402783}
Patch Set 1 #
Messages
Total messages: 23 (11 generated)
Description was changed from ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" ========== to ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + adrian.belgun@intel.com, piman@chromium.org
piman@ could you review? It's the 1st CL of https://bugs.chromium.org/p/chromium/issues/detail?id=535198#c16
lgtm
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
Description was changed from ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
On 2016/06/29 11:28:02, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu... is in trouble, so skip the test.
On 2016/06/29 11:28:02, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu... is in trouble, so skip the test.
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== gpu, cmaa: bottom to top is always y-direction. Current shader regards y-direction as either bottom-to-top or top-to-bottom case by case. It causes lots of difficulty to read the code. Make it consistent. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/2d46d1e224b05b216700efff90d4e7374b958d2d Cr-Commit-Position: refs/heads/master@{#402783} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2d46d1e224b05b216700efff90d4e7374b958d2d Cr-Commit-Position: refs/heads/master@{#402783} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
