[builtins] Add receiver to builtin exit frames

src/arm/builtins-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_ARM
 
 #include "src/codegen.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 17 matching lines @@
   //  -- sp[4 * argc]       : receiver
   // -----------------------------------
   __ AssertFunction(r1);
 
   // Make sure we operate in the context of the called function (for example
   // ConstructStubs implemented in C++ will be run in the context of the caller
   // instead of the callee, due to the way that [[Construct]] is defined for
   // ordinary functions).
   __ ldr(cp, FieldMemOperand(r1, JSFunction::kContextOffset));
 
-  // Insert extra arguments.
-  const int num_extra_args = 2;
-  __ Push(r1, r3);
-
   // JumpToExternalReference expects r0 to contain the number of arguments
   // including the receiver and the extra arguments.
+  const int num_extra_args = 3;
   __ add(r0, r0, Operand(num_extra_args + 1));
 
+  // Insert extra arguments.
+  __ SmiTag(r0);

[Yang, 2016/06/30 12:34:23]

Since we now make the distinction between builtin-exit and normal exit, couldn't
we move part of this adaptor into the CEntryStub? The difference being that we
generate CEntryStub only once, but an adaptor for every builtin.

[jgruber, 2016/06/30 14:40:29]

Not without larger changes, since HandleApiCall* builtins don't use BUILTIN_EXIT
frames, but still expect extra arguments on the stack.  CEntryStub can't tell
the difference between HandleApiCall* and other C builtins.

If we really want to do this, we'd have to revert
https://codereview.chromium.org/2074063002 and go from there.

[jgruber, 2016/06/30 14:45:47]

I guess we could also pass in whether we're calling from GenerateAdaptor, but
that seems like a bit of a hack.

+  __ Push(r0, r1, r3);
+  __ SmiUntag(r0);
+
   __ JumpToExternalReference(ExternalReference(id, masm->isolate()),
                              exit_frame_type == BUILTIN_EXIT);
 }
 
 
 // Load the built-in InternalArray function from the current context.
 static void GenerateLoadInternalArrayFunction(MacroAssembler* masm,
                                               Register result) {
   // Load the InternalArray function from the current native context.
   __ LoadNativeContextSlot(Context::INTERNAL_ARRAY_FUNCTION_INDEX, result);
@@ skipping 2822 matching lines @@
   }
 }
 
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM