Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2074063002: [builtins] Always pass target and new target to C++ builtins (Closed)

Created:
4 years, 6 months ago by jgruber
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Always pass target and new target to C++ builtins As a first step towards showing builtin frames in stack traces, we will now push target and new target unconditionally. Since the various specializations of BuiltinArguments are made redundant by this change, we can remove them and all related code. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/f5b83dec4ebd8c786292073cc45a078d716fba0b Cr-Commit-Position: refs/heads/master@{#37061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -421 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M src/builtins.h View 5 chunks +142 lines, -157 lines 0 comments Download
M src/builtins.cc View 25 chunks +68 lines, -140 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/external-reference-table.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +6 lines, -17 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074063002/1
4 years, 6 months ago (2016-06-17 09:30:50 UTC) #2
jgruber
4 years, 6 months ago (2016-06-17 09:31:44 UTC) #3
Benedikt Meurer
Nice, LGTM.
4 years, 6 months ago (2016-06-17 09:35:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 10:00:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074063002/1
4 years, 6 months ago (2016-06-17 10:00:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 10:17:11 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 10:20:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5b83dec4ebd8c786292073cc45a078d716fba0b
Cr-Commit-Position: refs/heads/master@{#37061}

Powered by Google App Engine
This is Rietveld 408576698