Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2106863006: Get rid of unused parameter RecalcStyleBehavior (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unused parameter RecalcStyleBehavior This patch gets rid of unused parameter |RecalcStyleBehavior| from - CharacterData::deleteData() - CharacterData::insertData() - and called functions from them to reduce code size for improving code health. BUG=n/a TEST=n/a; no behavior Committed: https://crrev.com/6d3cf449c091eeda6be260d55eeeeef119ad334b Cr-Commit-Position: refs/heads/master@{#403100}

Patch Set 1 : 2016-06-30T13:23:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M third_party/WebKit/Source/core/dom/CharacterData.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CharacterData.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-06-30 06:08:53 UTC) #3
tkent
lgtm
4 years, 5 months ago (2016-06-30 06:24:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106863006/1
4 years, 5 months ago (2016-06-30 06:24:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 06:29:14 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 06:29:20 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 06:32:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d3cf449c091eeda6be260d55eeeeef119ad334b
Cr-Commit-Position: refs/heads/master@{#403100}

Powered by Google App Engine
This is Rietveld 408576698