Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Side by Side Diff: third_party/WebKit/Source/core/dom/Text.cpp

Issue 2106863006: Get rid of unused parameter RecalcStyleBehavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-06-30T13:23:43 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Text.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 if (!textNode.textLayoutObjectIsNeeded(*textLayoutObject->style(), *textLayo utObject->parent())) 415 if (!textNode.textLayoutObjectIsNeeded(*textLayoutObject->style(), *textLayo utObject->parent()))
416 return true; 416 return true;
417 if (textLayoutObject->isTextFragment()) { 417 if (textLayoutObject->isTextFragment()) {
418 // Changes of |textNode| may change first letter part, so we should 418 // Changes of |textNode| may change first letter part, so we should
419 // reattach. 419 // reattach.
420 return toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement( ); 420 return toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement( );
421 } 421 }
422 return false; 422 return false;
423 } 423 }
424 424
425 void Text::updateTextLayoutObject(unsigned offsetOfReplacedData, unsigned length OfReplacedData, RecalcStyleBehavior recalcStyleBehavior) 425 void Text::updateTextLayoutObject(unsigned offsetOfReplacedData, unsigned length OfReplacedData)
426 { 426 {
427 if (!inActiveDocument()) 427 if (!inActiveDocument())
428 return; 428 return;
429 LayoutText* textLayoutObject = layoutObject(); 429 LayoutText* textLayoutObject = layoutObject();
430 if (shouldUpdateLayoutByReattaching(*this, textLayoutObject)) { 430 if (shouldUpdateLayoutByReattaching(*this, textLayoutObject)) {
431 lazyReattachIfAttached(); 431 lazyReattachIfAttached();
432 // FIXME: Editing should be updated so this is not neccesary.
433 if (recalcStyleBehavior == DeprecatedRecalcStyleImmediatlelyForEditing)
434 document().updateStyleAndLayoutTree();
435 return; 432 return;
436 } 433 }
437 textLayoutObject->setTextWithOffset(dataImpl(), offsetOfReplacedData, length OfReplacedData); 434 textLayoutObject->setTextWithOffset(dataImpl(), offsetOfReplacedData, length OfReplacedData);
438 } 435 }
439 436
440 Text* Text::cloneWithData(const String& data) 437 Text* Text::cloneWithData(const String& data)
441 { 438 {
442 return create(document(), data); 439 return create(document(), data);
443 } 440 }
444 441
(...skipping 16 matching lines...) Expand all
461 result.append("; "); 458 result.append("; ");
462 result.append("value="); 459 result.append("value=");
463 result.append(s); 460 result.append(s);
464 } 461 }
465 462
466 strncpy(buffer, result.toString().utf8().data(), length - 1); 463 strncpy(buffer, result.toString().utf8().data(), length - 1);
467 } 464 }
468 #endif 465 #endif
469 466
470 } // namespace blink 467 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Text.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698