Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2106793002: Add loading metrics owner entry for loadtimes_extension_bindings (Closed)

Created:
4 years, 5 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add loading metrics owner entry for loadtimes_extension_bindings BUG=621512 Committed: https://crrev.com/7b1c45eea8eda457180d981fd077cc1042680844 Cr-Commit-Position: refs/heads/master@{#403189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/renderer/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Bryan McQuade
PTAL
4 years, 5 months ago (2016-06-28 14:23:23 UTC) #2
jochen (gone - plz use gerrit)
what's the plan for this file? Are you signing up for rewriting it?
4 years, 5 months ago (2016-06-29 15:15:47 UTC) #3
Bryan McQuade
On 2016/06/29 at 15:15:47, jochen wrote: > what's the plan for this file? Are you ...
4 years, 5 months ago (2016-06-29 16:13:48 UTC) #4
jochen (gone - plz use gerrit)
if you touch this, please consider changing the bindings to be gin based instead of ...
4 years, 5 months ago (2016-06-30 15:13:55 UTC) #6
Bryan McQuade
Thanks! Shubhie, maybe we should also migrate to gin bindings as part of our work. ...
4 years, 5 months ago (2016-06-30 15:32:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106793002/1
4 years, 5 months ago (2016-06-30 15:32:13 UTC) #9
panicker
On 2016/06/30 15:32:13, Bryan McQuade wrote: > Thanks! Shubhie, maybe we should also migrate to ...
4 years, 5 months ago (2016-06-30 16:05:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 16:07:09 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 16:07:16 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 16:09:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b1c45eea8eda457180d981fd077cc1042680844
Cr-Commit-Position: refs/heads/master@{#403189}

Powered by Google App Engine
This is Rietveld 408576698