|
|
Created:
4 years, 5 months ago by Bryan McQuade Modified:
4 years, 5 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd loading metrics owner entry for loadtimes_extension_bindings
BUG=621512
Committed: https://crrev.com/7b1c45eea8eda457180d981fd077cc1042680844
Cr-Commit-Position: refs/heads/master@{#403189}
Patch Set 1 #
Messages
Total messages: 14 (4 generated)
bmcquade@chromium.org changed reviewers: + jochen@chromium.org
PTAL
what's the plan for this file? Are you signing up for rewriting it?
On 2016/06/29 at 15:15:47, jochen wrote: > what's the plan for this file? Are you signing up for rewriting it? Longer term, we'd like to deprecate it and see it go away, steering developers towards standardized APIs like navigation timing. I don't anticipate making any significant investments like rewrites, since the hope is that this code can eventually be removed. It's a long process. We want to 1. update the existing implementation to at least use a timing source we trust 2. better understand how often these APIs are used in the wild and whether/why developers are still using them 3. migrate users away from this API 4. eventually, if we're lucky, turn the API down I opened a tracking bug for this work here: https://bugs.chromium.org/p/chromium/issues/detail?id=621512 For now, I'm hoping to address step 1 in M54. Shubhie and I will be collaborating on the later steps.
Description was changed from ========== Add loading metrics owner entry for loadtimes_extension_bindings ========== to ========== Add loading metrics owner entry for loadtimes_extension_bindings BUG=621512 ==========
if you touch this, please consider changing the bindings to be gin based instead of being a v8::Extensions. v8 extensions have a non-trivial impact on startup. See e.g. https://codereview.chromium.org/163683004 for an example lgtm anyways
The CQ bit was checked by bmcquade@chromium.org
Thanks! Shubhie, maybe we should also migrate to gin bindings as part of our work. Perhaps we can do that as part of writing the code to add use counters. On Thu, Jun 30, 2016 at 11:13 AM <jochen@chromium.org> wrote: > if you touch this, please consider changing the bindings to be gin based > instead > of being a v8::Extensions. v8 extensions have a non-trivial impact on > startup. > See e.g. https://codereview.chromium.org/163683004 for an example > > lgtm anyways > > https://codereview.chromium.org/2106793002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/06/30 15:32:13, Bryan McQuade wrote: > Thanks! Shubhie, maybe we should also migrate to gin bindings as part of > our work. Perhaps we can do that as part of writing the code to add use > counters. Yep worth looking into. > > On Thu, Jun 30, 2016 at 11:13 AM <mailto:jochen@chromium.org> wrote: > > > if you touch this, please consider changing the bindings to be gin based > > instead > > of being a v8::Extensions. v8 extensions have a non-trivial impact on > > startup. > > See e.g. https://codereview.chromium.org/163683004 for an example > > > > lgtm anyways > > > > https://codereview.chromium.org/2106793002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Add loading metrics owner entry for loadtimes_extension_bindings BUG=621512 ========== to ========== Add loading metrics owner entry for loadtimes_extension_bindings BUG=621512 Committed: https://crrev.com/7b1c45eea8eda457180d981fd077cc1042680844 Cr-Commit-Position: refs/heads/master@{#403189} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7b1c45eea8eda457180d981fd077cc1042680844 Cr-Commit-Position: refs/heads/master@{#403189} |