Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 163683004: Implement WebUI extension via gin instead of v8::Extension (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Implement WebUI extension via gin instead of v8::Extension BUG=334679 R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251626

Patch Set 1 #

Total comments: 10

Patch Set 2 : updates #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -90 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/web_ui_extension.h View 1 chunk +12 lines, -5 lines 0 comments Download
M content/renderer/web_ui_extension.cc View 1 3 chunks +53 lines, -84 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-13 15:01:12 UTC) #1
jochen (gone - plz use gerrit)
+arv
6 years, 10 months ago (2014-02-13 15:02:44 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/163683004/diff/1/content/renderer/web_ui_extension.cc File content/renderer/web_ui_extension.cc (right): https://codereview.chromium.org/163683004/diff/1/content/renderer/web_ui_extension.cc#newcode77 content/renderer/web_ui_extension.cc:77: global->Set(gin::StringToSymbol(isolate, "chrome"), chrome); OT, Can we rename StringToSymbol before ...
6 years, 10 months ago (2014-02-13 15:34:51 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/163683004/diff/1/content/renderer/web_ui_extension.cc File content/renderer/web_ui_extension.cc (right): https://codereview.chromium.org/163683004/diff/1/content/renderer/web_ui_extension.cc#newcode77 content/renderer/web_ui_extension.cc:77: global->Set(gin::StringToSymbol(isolate, "chrome"), chrome); On 2014/02/13 15:34:51, arv wrote: > ...
6 years, 10 months ago (2014-02-13 15:44:23 UTC) #4
arv (Not doing code reviews)
LGTM gin bindings look really great and makes the code much cleaner too. https://codereview.chromium.org/163683004/diff/1/content/renderer/web_ui_extension.cc File ...
6 years, 10 months ago (2014-02-13 15:55:17 UTC) #5
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 10 months ago (2014-02-13 16:37:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/163683004/2
6 years, 10 months ago (2014-02-13 16:38:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 16:38:16 UTC) #8
commit-bot: I haz the power
Failed to apply patch for content/renderer/render_view_impl.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-13 16:38:16 UTC) #9
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 10 months ago (2014-02-16 09:56:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/163683004/210001
6 years, 10 months ago (2014-02-16 09:56:24 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-16 10:15:25 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chromedriver_unittests, ...
6 years, 10 months ago (2014-02-16 10:15:26 UTC) #13
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 10 months ago (2014-02-16 10:15:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/163683004/210001
6 years, 10 months ago (2014-02-16 10:16:08 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-16 22:19:46 UTC) #16
Message was sent while issue was closed.
Change committed as 251626

Powered by Google App Engine
This is Rietveld 408576698