content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content-offset -> top-controls-shown renaming and respond to bokan's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java ('k') | content/renderer/gpu/render_widget_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java b/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

index 443e7d25a4c660083b3906c8b44f6f471bfc4050..8c19de3c324ee258d0ae50daf215d457de01e2a5 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

@@ -167,7 +167,7 @@ final class CursorAnchorInfoController {

// screen coordinate. Hence the following values are derived.

float scale = renderCoordinates.getDeviceScaleFactor();

float translationX = mViewOrigin[0];

- float translationY = mViewOrigin[1] + renderCoordinates.getContentOffsetYPix();

+ float translationY = mViewOrigin[1] + renderCoordinates.getTopControlsShownYPix();

if (!mHasCoordinateInfo

|| scale != mScale