content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content-offset -> top-controls-shown renaming and respond to bokan's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index 2157ce4357ac8de8c728523e4c98868f16852340..f18f86a02e58256c98f3b743c04b3b15a791efde 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -864,7 +864,7 @@ public class BrowserAccessibilityManager {

parentRelativeLeft + width, parentRelativeTop + height);

if (isRootNode) {

// Offset of the web content relative to the View.

- boundsInParent.offset(0, (int) mRenderCoordinates.getContentOffsetYPix());

+ boundsInParent.offset(0, (int) mRenderCoordinates.getTopControlsShownYPix());

}

node.setBoundsInParent(boundsInParent);

@@ -883,7 +883,7 @@ public class BrowserAccessibilityManager {

// Offset by the location of the web content within the view.

rect.offset(0,

- (int) mRenderCoordinates.getContentOffsetYPix());

+ (int) mRenderCoordinates.getTopControlsShownYPix());

// Finally offset by the location of the view within the screen.

final int[] viewLocation = new int[2];

@@ -891,7 +891,7 @@ public class BrowserAccessibilityManager {

rect.offset(viewLocation[0], viewLocation[1]);

// Clip the node's bounding rect to the viewport bounds.

- int viewportRectTop = viewLocation[1] + (int) mRenderCoordinates.getContentOffsetYPix();

+ int viewportRectTop = viewLocation[1] + (int) mRenderCoordinates.getTopControlsShownYPix();

int viewportRectBottom = viewportRectTop + mContentViewCore.getViewportHeightPix();

if (rect.top < viewportRectTop) rect.top = viewportRectTop;

if (rect.bottom > viewportRectBottom) rect.bottom = viewportRectBottom;