components/arc/arc_bridge_service.cc - Issue 2106663004: arc: Initial implemetation of Chrome sync for Arc packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/arc_bridge_service.cc

Issue 2106663004: arc: Initial implemetation of Chrome sync for Arc packages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. More refactor. Fix unit_test related to refactor. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/arc/arc_package_syncable_service.h ('K') | « chrome/chrome_browser_ui.gypi ('k') | components/arc/instance_holder.h » ('j') | components/arc/instance_holder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/arc/arc_bridge_service.cc

diff --git a/components/arc/arc_bridge_service.cc b/components/arc/arc_bridge_service.cc

index 34e31bb83f164be2c59dcd37d647e1bef7f02cd2..684b92b7883fc978c083d22354d9dcacd2f0c655 100644

--- a/components/arc/arc_bridge_service.cc

+++ b/components/arc/arc_bridge_service.cc

@@ -61,8 +61,10 @@ void ArcBridgeService::SetState(State state) {

VLOG(2) << "State: " << static_cast<uint32_t>(state_);

if (state_ == State::READY)

FOR_EACH_OBSERVER(Observer, observer_list(), OnBridgeReady());

- else if (state == State::STOPPED)

+ else if (state == State::STOPPED) {

FOR_EACH_OBSERVER(Observer, observer_list(), OnBridgeStopped(stop_reason_));

+ app_.CloseChannel();

Luis Héctor Chávez 2016/07/20 00:01:15 Hmmmm I don't like this. Is there any way you can

+ }

}

void ArcBridgeService::SetAvailable(bool available) {

« chrome/browser/ui/app_list/arc/arc_package_syncable_service.h ('K') | « chrome/chrome_browser_ui.gypi ('k') | components/arc/instance_holder.h » ('j') | components/arc/instance_holder.h » ('J')