components/arc/instance_holder.h - Issue 2106663004: arc: Initial implemetation of Chrome sync for Arc packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/instance_holder.h

Issue 2106663004: arc: Initial implemetation of Chrome sync for Arc packages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. More refactor. Fix unit_test related to refactor. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/arc/instance_holder.h

diff --git a/components/arc/instance_holder.h b/components/arc/instance_holder.h

index 2d22f759b0b73dc921e0ecdf538cf45a1b3a3252..67e98292a535b661597a1bcaeb109f71fac74dcd 100644

--- a/components/arc/instance_holder.h

+++ b/components/arc/instance_holder.h

@@ -62,7 +62,7 @@ class InstanceHolder {

// Called when the channel is closed.

void CloseChannel() {

- if (!ptr_)

+ if (!ptr_ && !raw_ptr_)

Luis Héctor Chávez 2016/07/20 00:01:15 Why is this needed?

lgcheng 2016/07/20 01:23:58 In test, ptr_ is never set. only raw_ptr_ is set.

return;

ptr_.reset();

« components/arc/arc_bridge_service.cc ('K') | « components/arc/arc_bridge_service.cc ('k') | no next file » | no next file with comments »