Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 210663003: Use |isolate| local variable in bindings, clean up comments (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Use |isolate| local variable in bindings, clean up comments This removes 6 FIXMEs, and removes duplicate calls of info.GetIsolate(). This updates the license block to the new form (since this is *generated* code), and makes it automatically use the correct module name. I didn't make the year update automatically, as otherwise r-b-t will break every new year and this detail doesn't seem worth the hassle. I also moved one long comment into a template comment, so it's not in the generated code. This seems clearer (it's in the template), and reduces duplication and noise. Overall these reduce the size of the generated code and tests by about 6% (generated code from 17 MB from 16 MB)! Not a big deal, but makes them a bit faster to compile and easier to read. R=haraken BUG=345503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169910

Patch Set 1 #

Patch Set 2 : Update extension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -2342 lines) Patch
M Source/bindings/scripts/code_generator_v8.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/bindings/templates/callback_interface.h View 1 chunk +4 lines, -32 lines 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 chunk +4 lines, -32 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +4 lines, -32 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 7 chunks +19 lines, -16 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 2 chunks +12 lines, -36 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 5 chunks +11 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallbackInterface.h View 1 1 chunk +4 lines, -30 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallbackInterface.cpp View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 3 chunks +9 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 5 chunks +13 lines, -41 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 16 chunks +43 lines, -65 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 4 chunks +15 lines, -43 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 4 chunks +10 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 1 4 chunks +7 lines, -36 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 4 chunks +12 lines, -41 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.cpp View 1 3 chunks +7 lines, -36 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 4 chunks +7 lines, -36 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 3 chunks +7 lines, -36 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 3 chunks +9 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 3 chunks +9 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 1 3 chunks +9 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 3 chunks +9 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 1 2 chunks +5 lines, -35 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 3 chunks +9 lines, -38 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 1 chunk +5 lines, -31 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 4 chunks +7 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nils Barth (inactive)
Some cleanup.
6 years, 9 months ago (2014-03-25 03:02:06 UTC) #1
haraken
LGTM. Looking at the CL, you might want to reduce # of run-bindings-tests :)
6 years, 9 months ago (2014-03-25 03:05:13 UTC) #2
Nils Barth (inactive)
On 2014/03/25 03:05:13, haraken wrote: > Looking at the CL, you might want to reduce ...
6 years, 9 months ago (2014-03-25 03:06:04 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-25 03:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/210663003/20001
6 years, 9 months ago (2014-03-25 03:06:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 03:43:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-25 03:43:29 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-25 04:52:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/210663003/20001
6 years, 9 months ago (2014-03-25 04:52:32 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 05:29:56 UTC) #10
Message was sent while issue was closed.
Change committed as 169910

Powered by Google App Engine
This is Rietveld 408576698