|
Use |isolate| local variable in bindings, clean up comments
This removes 6 FIXMEs, and removes duplicate calls of info.GetIsolate().
This updates the license block to the new form (since this is *generated* code),
and makes it automatically use the correct module name.
I didn't make the year update automatically, as otherwise r-b-t will break
every new year and this detail doesn't seem worth the hassle.
I also moved one long comment into a template comment, so it's not in the
generated code. This seems clearer (it's in the template), and reduces
duplication and noise.
Overall these reduce the size of the generated code and tests
by about 6% (generated code from 17 MB from 16 MB)!
Not a big deal, but makes them a bit faster to compile and easier to read.
R=haraken
BUG= 345503
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169910
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+479 lines, -2342 lines) |
Patch |
 |
M |
Source/bindings/scripts/code_generator_v8.py
|
View
|
1
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/callback_interface.h
|
View
|
|
1 chunk |
+4 lines, -32 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/callback_interface.cpp
|
View
|
|
1 chunk |
+4 lines, -32 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/interface.h
|
View
|
|
1 chunk |
+4 lines, -32 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/interface.cpp
|
View
|
|
7 chunks |
+19 lines, -16 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/interface_base.cpp
|
View
|
|
2 chunks |
+12 lines, -36 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/templates/methods.cpp
|
View
|
|
5 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8SVGTestInterface.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8SVGTestInterface.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestCallbackInterface.h
|
View
|
1
|
1 chunk |
+4 lines, -30 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestCallbackInterface.cpp
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestEventTarget.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestEventTarget.cpp
|
View
|
1
|
3 chunks |
+9 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestException.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestException.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterface.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterface.cpp
|
View
|
1
|
5 chunks |
+13 lines, -41 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp
|
View
|
1
|
16 chunks |
+43 lines, -65 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor.cpp
|
View
|
1
|
4 chunks |
+15 lines, -43 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor2.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp
|
View
|
1
|
4 chunks |
+10 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor3.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp
|
View
|
1
|
4 chunks |
+7 lines, -36 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceDocument.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceDocument.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEmpty.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEmpty.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEventConstructor.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
|
View
|
1
|
4 chunks |
+12 lines, -41 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEventTarget.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNode.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNode.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython2.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython2.cpp
|
View
|
1
|
3 chunks |
+7 lines, -36 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython3.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython3.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp
|
View
|
1
|
4 chunks |
+7 lines, -36 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestNode.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestNode.cpp
|
View
|
1
|
3 chunks |
+7 lines, -36 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestObject.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestObject.cpp
|
View
|
1
|
3 chunks |
+9 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestObjectPython.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestObjectPython.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp
|
View
|
1
|
3 chunks |
+9 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsCustom.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp
|
View
|
1
|
3 chunks |
+9 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsInt.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp
|
View
|
1
|
3 chunks |
+9 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp
|
View
|
1
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp
|
View
|
1
|
3 chunks |
+9 lines, -38 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestTypedefs.h
|
View
|
1
|
1 chunk |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestTypedefs.cpp
|
View
|
1
|
4 chunks |
+7 lines, -36 lines |
0 comments
|
Download
|
Total messages: 10 (0 generated)
|