Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp - Issue 210663003: Use |isolate| local variable in bindings, clean up comments

Unified Diff: Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

Issue 210663003: Use |isolate| local variable in bindings, clean up comments (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update extension Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp b/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

index 5edfabfdc0f6d155243f992007005a4e3760698d..e609da0b085ee0b066e27b01587de635d1d688fa 100644

--- a/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp

@@ -1,34 +1,8 @@

-/*

- *

- * Redistribution and use in source and binary forms, with or without

- * modification, are permitted provided that the following conditions are

- * met:

- *

- * * Redistributions of source code must retain the above copyright

- * notice, this list of conditions and the following disclaimer.

- * * Redistributions in binary form must reproduce the above

- * copyright notice, this list of conditions and the following disclaimer

- * in the documentation and/or other materials provided with the

- * distribution.

- * * Neither the name of Google Inc. nor the names of its

- * contributors may be used to endorse or promote products derived from

- * this software without specific prior written permission.

- *

- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR

- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT

- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

- */

-// This file has been auto-generated by code_generator_v8.pm. DO NOT MODIFY!

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+// This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!

#include "config.h"

#include "V8TestInterfaceCheckSecurity.h"

@@ -57,10 +31,6 @@ static void initializeScriptWrappableForInterface(TestInterfaceCheckSecurity* ob

} // namespace WebCore

-// In ScriptWrappable::init, the use of a local function declaration has an issue on Windows:

-// the local declaration does not pick up the surrounding namespace. Therefore, we provide this function

-// in the global namespace.

-// (More info on the MSVC bug here: http://connect.microsoft.com/VisualStudio/feedback/details/664619/the-namespace-of-local-function-declarations-in-c)

void webCoreInitializeScriptWrappableForInterface(WebCore::TestInterfaceCheckSecurity* object)

{

WebCore::initializeScriptWrappableForInterface(object);

@@ -171,9 +141,10 @@ static void doNotCheckSecurityReplaceableReadonlyLongAttributeAttributeGetterCal

static void TestInterfaceCheckSecurityReplaceableAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)

{

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(info.Holder());

+ v8::Isolate* isolate = info.GetIsolate();

v8::String::Utf8Value attributeName(name);

- ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "TestInterfaceCheckSecurity", info.Holder(), info.GetIsolate());

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), exceptionState)) {

+ ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "TestInterfaceCheckSecurity", info.Holder(), isolate);

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), exceptionState)) {

exceptionState.throwIfNeeded();

return;

}

@@ -230,11 +201,12 @@ static void doNotCheckSecurityVoidMethodMethodCallback(const v8::FunctionCallbac

static void doNotCheckSecurityVoidMethodOriginSafeMethodGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

+ v8::Isolate* isolate = info.GetIsolate();

static int domTemplateKey; // This address is used for a key to look up the dom template.

- V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());

+ V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> privateTemplate = data->domTemplate(&domTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty()) {

// This is only reachable via |object.__proto__.func|, in which case it

// has already passed the same origin security check

@@ -242,14 +214,14 @@ static void doNotCheckSecurityVoidMethodOriginSafeMethodGetter(const v8::Propert

return;

}

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), DoNotReportSecurityError)) {

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), DoNotReportSecurityError)) {

static int sharedTemplateKey; // This address is used for a key to look up the dom template.

v8::Handle<v8::FunctionTemplate> sharedTemplate = data->domTemplate(&sharedTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

v8SetReturnValue(info, sharedTemplate->GetFunction());

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityVoidMethod"));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(isolate, "doNotCheckSecurityVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -280,11 +252,12 @@ static void doNotCheckSecurityDoNotCheckSignatureVoidMethodMethodCallback(const

static void doNotCheckSecurityDoNotCheckSignatureVoidMethodOriginSafeMethodGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

+ v8::Isolate* isolate = info.GetIsolate();

static int domTemplateKey; // This address is used for a key to look up the dom template.

- V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());

+ V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> privateTemplate = data->domTemplate(&domTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityDoNotCheckSignatureVoidMethodMethodCallback, v8Undefined(), v8::Local<v8::Signature>(), 0);

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty()) {

// This is only reachable via |object.__proto__.func|, in which case it

// has already passed the same origin security check

@@ -292,14 +265,14 @@ static void doNotCheckSecurityDoNotCheckSignatureVoidMethodOriginSafeMethodGette

return;

}

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), DoNotReportSecurityError)) {

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), DoNotReportSecurityError)) {

static int sharedTemplateKey; // This address is used for a key to look up the dom template.

v8::Handle<v8::FunctionTemplate> sharedTemplate = data->domTemplate(&sharedTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityDoNotCheckSignatureVoidMethodMethodCallback, v8Undefined(), v8::Local<v8::Signature>(), 0);

v8SetReturnValue(info, sharedTemplate->GetFunction());

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityDoNotCheckSignatureVoidMethod"));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(isolate, "doNotCheckSecurityDoNotCheckSignatureVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -330,11 +303,12 @@ static void doNotCheckSecurityPerWorldBindingsVoidMethodMethodCallback(const v8:

static void doNotCheckSecurityPerWorldBindingsVoidMethodOriginSafeMethodGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

+ v8::Isolate* isolate = info.GetIsolate();

static int domTemplateKey; // This address is used for a key to look up the dom template.

- V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());

+ V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> privateTemplate = data->domTemplate(&domTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityPerWorldBindingsVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty()) {

// This is only reachable via |object.__proto__.func|, in which case it

// has already passed the same origin security check

@@ -342,14 +316,14 @@ static void doNotCheckSecurityPerWorldBindingsVoidMethodOriginSafeMethodGetter(c

return;

}

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), DoNotReportSecurityError)) {

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), DoNotReportSecurityError)) {

static int sharedTemplateKey; // This address is used for a key to look up the dom template.

v8::Handle<v8::FunctionTemplate> sharedTemplate = data->domTemplate(&sharedTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityPerWorldBindingsVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

v8SetReturnValue(info, sharedTemplate->GetFunction());

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityPerWorldBindingsVoidMethod"));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(isolate, "doNotCheckSecurityPerWorldBindingsVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -380,11 +354,12 @@ static void doNotCheckSecurityPerWorldBindingsVoidMethodMethodCallbackForMainWor

static void doNotCheckSecurityPerWorldBindingsVoidMethodOriginSafeMethodGetterForMainWorld(const v8::PropertyCallbackInfo<v8::Value>& info)

{

+ v8::Isolate* isolate = info.GetIsolate();

static int domTemplateKey; // This address is used for a key to look up the dom template.

- V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());

+ V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> privateTemplate = data->domTemplate(&domTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityPerWorldBindingsVoidMethodMethodCallbackForMainWorld, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty()) {

// This is only reachable via |object.__proto__.func|, in which case it

// has already passed the same origin security check

@@ -392,14 +367,14 @@ static void doNotCheckSecurityPerWorldBindingsVoidMethodOriginSafeMethodGetterFo

return;

}

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), DoNotReportSecurityError)) {

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), DoNotReportSecurityError)) {

static int sharedTemplateKey; // This address is used for a key to look up the dom template.

v8::Handle<v8::FunctionTemplate> sharedTemplate = data->domTemplate(&sharedTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityPerWorldBindingsVoidMethodMethodCallbackForMainWorld, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

v8SetReturnValue(info, sharedTemplate->GetFunction());

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityPerWorldBindingsVoidMethod"));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(isolate, "doNotCheckSecurityPerWorldBindingsVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -430,11 +405,12 @@ static void doNotCheckSecurityReadOnlyVoidMethodMethodCallback(const v8::Functio

static void doNotCheckSecurityReadOnlyVoidMethodOriginSafeMethodGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

+ v8::Isolate* isolate = info.GetIsolate();

static int domTemplateKey; // This address is used for a key to look up the dom template.

- V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());

+ V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> privateTemplate = data->domTemplate(&domTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityReadOnlyVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty()) {

// This is only reachable via |object.__proto__.func|, in which case it

// has already passed the same origin security check

@@ -442,14 +418,14 @@ static void doNotCheckSecurityReadOnlyVoidMethodOriginSafeMethodGetter(const v8:

return;

}

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), DoNotReportSecurityError)) {

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), DoNotReportSecurityError)) {

static int sharedTemplateKey; // This address is used for a key to look up the dom template.

v8::Handle<v8::FunctionTemplate> sharedTemplate = data->domTemplate(&sharedTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityReadOnlyVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

v8SetReturnValue(info, sharedTemplate->GetFunction());

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityReadOnlyVoidMethod"));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(isolate, "doNotCheckSecurityReadOnlyVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -480,11 +456,12 @@ static void doNotCheckSecurityUnforgeableVoidMethodMethodCallback(const v8::Func

static void doNotCheckSecurityUnforgeableVoidMethodOriginSafeMethodGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

+ v8::Isolate* isolate = info.GetIsolate();

static int domTemplateKey; // This address is used for a key to look up the dom template.

- V8PerIsolateData* data = V8PerIsolateData::from(info.GetIsolate());

+ V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> privateTemplate = data->domTemplate(&domTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityUnforgeableVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty()) {

// This is only reachable via |object.__proto__.func|, in which case it

// has already passed the same origin security check

@@ -492,14 +469,14 @@ static void doNotCheckSecurityUnforgeableVoidMethodOriginSafeMethodGetter(const

return;

}

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), DoNotReportSecurityError)) {

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), DoNotReportSecurityError)) {

static int sharedTemplateKey; // This address is used for a key to look up the dom template.

v8::Handle<v8::FunctionTemplate> sharedTemplate = data->domTemplate(&sharedTemplateKey, TestInterfaceCheckSecurityV8Internal::doNotCheckSecurityUnforgeableVoidMethodMethodCallback, v8Undefined(), v8::Signature::New(info.GetIsolate(), V8TestInterfaceCheckSecurity::domTemplate(info.GetIsolate())), 0);

v8SetReturnValue(info, sharedTemplate->GetFunction());

return;

}

- v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(info.GetIsolate(), "doNotCheckSecurityUnforgeableVoidMethod"));

+ v8::Local<v8::Value> hiddenValue = info.This()->GetHiddenValue(v8AtomicString(isolate, "doNotCheckSecurityUnforgeableVoidMethod"));

if (!hiddenValue.IsEmpty()) {

v8SetReturnValue(info, hiddenValue);

return;

@@ -517,18 +494,19 @@ static void doNotCheckSecurityUnforgeableVoidMethodOriginSafeMethodGetterCallbac

static void TestInterfaceCheckSecurityOriginSafeMethodSetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)

{

- v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), info.GetIsolate());

+ v8::Isolate* isolate = info.GetIsolate();

+ v8::Handle<v8::Object> holder = V8TestInterfaceCheckSecurity::findInstanceInPrototypeChain(info.This(), isolate);

if (holder.IsEmpty())

return;

TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toNative(holder);

v8::String::Utf8Value attributeName(name);

- ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "TestInterfaceCheckSecurity", info.Holder(), info.GetIsolate());

- if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), exceptionState)) {

+ ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "TestInterfaceCheckSecurity", info.Holder(), isolate);

+ if (!BindingSecurity::shouldAllowAccessToFrame(isolate, impl->frame(), exceptionState)) {

exceptionState.throwIfNeeded();

return;

}

- V8HiddenValue::setHiddenValue(info.GetIsolate(), info.This(), name, jsValue);

+ V8HiddenValue::setHiddenValue(isolate, info.This(), name, jsValue);

}

static void TestInterfaceCheckSecurityOriginSafeMethodSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)