Fix the GN mini_installer_syzygy target.

Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as https://codereview.chromium.org/2091023007)

BUG=525752
Committed: https://crrev.com/6e7e6145668679861a2e91df372b6b75c861e4e8
Cr-Commit-Position: refs/heads/master@{#402573}

[Sébastien Marchand, 2016-06-27 23:59:16]

sebmarchand@chromium.org changed reviewers:
+ brettw@chromium.org, brucedawson@chromium.org

[Sébastien Marchand, 2016-06-27 23:59:17]

PTAL.

[Dirk Pranke, 2016-06-28 18:57:46]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-28 18:57:46]

lgtm

[Sébastien Marchand, 2016-06-28 19:04:58]

Description was changed from

==========
Fix the GN mini_installer_syzygy target.


BUG=525752
==========

to

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

BUG=525752
==========

[Sébastien Marchand, 2016-06-28 19:05:27]

sebmarchand@chromium.org changed reviewers:
+ gab@chromium.org

[Sébastien Marchand, 2016-06-28 19:05:28]

+gab@, owner for these 2 files. Can you take a quick look ? Thanks

[Sébastien Marchand, 2016-06-28 20:18:12]

Description was changed from

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

BUG=525752
==========

to

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in
https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as
https://codereview.chromium.org/2091023007)

BUG=525752
==========

[gab, 2016-06-28 20:29:29]

lgtm rubberstamp if it works (not closely familiar with 7za usage for
mini_installer)

[Sébastien Marchand, 2016-06-28 20:31:37]

Yep, did a few local tests and it works.

[Sébastien Marchand, 2016-06-28 20:31:47]

The CQ bit was checked by sebmarchand@chromium.org

[brettw, 2016-06-28 20:32:22]

lgtm

https://codereview.chromium.org/2106563002/diff/20001/chrome/installer/mini_i...
File chrome/installer/mini_installer/BUILD.gn (right):

https://codereview.chromium.org/2106563002/diff/20001/chrome/installer/mini_i...
chrome/installer/mini_installer/BUILD.gn:169: "$chrome_dll_target",
Just write
  chrome_dll_target,
(what you wrote does string interpolation of a string into another string that
has nothing else in it).

[Sébastien Marchand, 2016-06-28 20:32:52]

The CQ bit was unchecked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-06-28 20:36:13]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-06-28 20:36:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, gab@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2106563002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-06-28 20:37:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:22:43]

Description was changed from

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in
https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as
https://codereview.chromium.org/2091023007)

BUG=525752
==========

to

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in
https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as
https://codereview.chromium.org/2091023007)

BUG=525752
==========

[commit-bot: I haz the power, 2016-06-28 22:22:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-28 22:24:22]

Description was changed from

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in
https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as
https://codereview.chromium.org/2091023007)

BUG=525752
==========

to

==========
Fix the GN mini_installer_syzygy target.

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in
https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as
https://codereview.chromium.org/2091023007)

BUG=525752

Committed: https://crrev.com/6e7e6145668679861a2e91df372b6b75c861e4e8
Cr-Commit-Position: refs/heads/master@{#402573}
==========

[commit-bot: I haz the power, 2016-06-28 22:24:23]

Patchset 3 (id:??) landed as
https://crrev.com/6e7e6145668679861a2e91df372b6b75c861e4e8
Cr-Commit-Position: refs/heads/master@{#402573}