Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2106453002: [Cronet] Remove unused ping and windowUpdate methods (Closed)

Created:
4 years, 5 months ago by xunjieli
Modified:
4 years, 5 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Remove unused ping and windowUpdate methods BidirectionalStream.ping and BidirectionalStream.windowUpdate are unused. This CL removes them. We can consider adding them back if there are interests from consumers. BUG=516342 Committed: https://crrev.com/9d585f6cd6255ff10edd8f831337ba958262a04b Cr-Commit-Position: refs/heads/master@{#402604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
M components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java View 2 chunks +0 lines, -39 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xunjieli
4 years, 5 months ago (2016-06-27 18:14:08 UTC) #2
mef
lgtm
4 years, 5 months ago (2016-06-28 21:14:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106453002/1
4 years, 5 months ago (2016-06-28 22:19:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 23:55:26 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:57:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d585f6cd6255ff10edd8f831337ba958262a04b
Cr-Commit-Position: refs/heads/master@{#402604}

Powered by Google App Engine
This is Rietveld 408576698