Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

Issue 2106453002: [Cronet] Remove unused ping and windowUpdate methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
diff --git a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
index 75ac21688a7f8f36f78533b868305df66eec3ac8..40dcec95fbbd528bf98df0c52f45a46e40a7e8d8 100644
--- a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
+++ b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
@@ -322,28 +322,6 @@ public abstract class BidirectionalStream {
}
/**
- * A callback that is invoked when the acknowledgement to a {@link #ping ping()} is received.
- * Exactly one of the two methods will be invoked per each call to {@link #ping ping()}.
- */
- public abstract static class PingCallback {
- /**
- * Invoked when a ping is acknowledged. The given argument is the round-trip time of the
- * ping, in microseconds.
- *
- * @param roundTripTimeMicros the round-trip duration between the ping being sent and the
- * acknowledgement received
- */
- public abstract void pingAcknowledged(long roundTripTimeMicros);
-
- /**
- * Invoked when a ping fails. The given argument is the cause of the failure.
- *
- * @param cause the cause of the ping failure
- */
- public abstract void pingFailed(CronetException cause);
- }
-
- /**
* Starts the stream, all callbacks go to the {@code callback} argument passed to {@link
* BidirectionalStream.Builder}'s constructor. Should only be called once.
*/
@@ -407,23 +385,6 @@ public abstract class BidirectionalStream {
public abstract void flush();
/**
- * Pings remote end-point. {@code callback} methods will be invoked on {@code executor}.
- *
- * @param callback the callback that will be invoked when ping succeeds or fails
- * @param executor the executor on which the callback will be invoked
- */
- // TODO(mef): May be last thing to be implemented on Android.
- public abstract void ping(PingCallback callback, Executor executor);
-
- /**
- * Updates stream flow control window.
- *
- * @param windowSizeIncrement the value in bytes to increment window by. May be negative.
- */
- // TODO(mef): Understand the needs and semantics of this method.
- public abstract void windowUpdate(int windowSizeIncrement);
-
- /**
* Cancels the stream. Can be called at any time after {@link #start}.
* {@link Callback#onCanceled onCanceled()} will be invoked when cancelation
* is complete and no further callback methods will be invoked. If the
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698