ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm - Issue 2106353003: Enable Update Password UI on iOS behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Issue 2106353003: Enable Update Password UI on iOS behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@update_controller

Patch Set: Remove heuristics changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/passwords/ios_chrome_password_manager_client.h ('k') | ios/chrome/browser/passwords/password_controller.mm » ('j') | ios/chrome/browser/passwords/password_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

diff --git a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

index f24d098b23fa96cebb9cc813118274b4803b46b4..57af08940c5f031f85839c4f2aa442da6f13577f 100644

--- a/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

+++ b/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

@@ -74,7 +74,14 @@ bool IOSChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(

bool update_password) {

if (form_to_save->IsBlacklisted())

return false;

- [delegate_ showSavePasswordInfoBar:std::move(form_to_save)];

+ if (ios_internal::experimental_flags::IsUpdatePasswordUIEnabled() &&

sdefresne 2016/07/05 13:29:55 I think this should be "experimental_flags::IsUpda

Jackie Quinn 2016/07/05 13:52:34 Yes, thanks. Done.

+ update_password) {

+ [delegate_ showUpdatePasswordInfoBar:std::move(form_to_save)];

+ } else {

+ [delegate_ showSavePasswordInfoBar:std::move(form_to_save)];

+ }

return true;

}