Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm

Issue 2106353003: Enable Update Password UI on iOS behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@update_controller
Patch Set: Remove heuristics changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/passwords/ios_chrome_password_manager_client.h" 5 #import "ios/chrome/browser/passwords/ios_chrome_password_manager_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "components/autofill/core/common/password_form.h" 10 #include "components/autofill/core/common/password_form.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 NOTIMPLEMENTED(); 67 NOTIMPLEMENTED();
68 return false; 68 return false;
69 } 69 }
70 70
71 bool IOSChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword( 71 bool IOSChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
72 std::unique_ptr<PasswordFormManager> form_to_save, 72 std::unique_ptr<PasswordFormManager> form_to_save,
73 password_manager::CredentialSourceType type, 73 password_manager::CredentialSourceType type,
74 bool update_password) { 74 bool update_password) {
75 if (form_to_save->IsBlacklisted()) 75 if (form_to_save->IsBlacklisted())
76 return false; 76 return false;
77 [delegate_ showSavePasswordInfoBar:std::move(form_to_save)]; 77
78 if (ios_internal::experimental_flags::IsUpdatePasswordUIEnabled() &&
sdefresne 2016/07/05 13:29:55 I think this should be "experimental_flags::IsUpda
Jackie Quinn 2016/07/05 13:52:34 Yes, thanks. Done.
79 update_password) {
80 [delegate_ showUpdatePasswordInfoBar:std::move(form_to_save)];
81 } else {
82 [delegate_ showSavePasswordInfoBar:std::move(form_to_save)];
83 }
84
78 return true; 85 return true;
79 } 86 }
80 87
81 void IOSChromePasswordManagerClient::AutomaticPasswordSave( 88 void IOSChromePasswordManagerClient::AutomaticPasswordSave(
82 std::unique_ptr<PasswordFormManager> saved_form_manager) { 89 std::unique_ptr<PasswordFormManager> saved_form_manager) {
83 NOTIMPLEMENTED(); 90 NOTIMPLEMENTED();
84 } 91 }
85 92
86 bool IOSChromePasswordManagerClient::IsOffTheRecord() const { 93 bool IOSChromePasswordManagerClient::IsOffTheRecord() const {
87 return (delegate_.browserState)->IsOffTheRecord(); 94 return (delegate_.browserState)->IsOffTheRecord();
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 } 128 }
122 129
123 const GURL& IOSChromePasswordManagerClient::GetLastCommittedEntryURL() const { 130 const GURL& IOSChromePasswordManagerClient::GetLastCommittedEntryURL() const {
124 return delegate_.lastCommittedURL; 131 return delegate_.lastCommittedURL;
125 } 132 }
126 133
127 const password_manager::CredentialsFilter* 134 const password_manager::CredentialsFilter*
128 IOSChromePasswordManagerClient::GetStoreResultFilter() const { 135 IOSChromePasswordManagerClient::GetStoreResultFilter() const {
129 return &credentials_filter_; 136 return &credentials_filter_;
130 } 137 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698