Issue 2106333003: Disallow identical names for the Encryption and Crypto-Key headers

Issue 2106333003: Disallow identical names for the Encryption and Crypto-Key headers (Closed)

Created:
4 years, 5 months ago by Peter Beverloo

Modified:
4 years, 5 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@headers-changes

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Disallow identical names for the Encryption and Crypto-Key headers This is to be enforced per the following spec change: https://github.com/martinthomson/http-encryption/commit/d11c8263ef3a9fa9cec261898b5d462162045099 BUG=538576 Committed: https://crrev.com/7da94ee9792c09e05911e80d5a2d5266ed547bf4 Cr-Commit-Position: refs/heads/master@{#403352}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -6 lines)			Patch
	M	components/gcm_driver/crypto/encryption_header_parsers.cc	View		4 chunks	+22 lines, -4 lines	0 comments	Download
	M	components/gcm_driver/crypto/encryption_header_parsers_unittest.cc	View	1	4 chunks	+8 lines, -2 lines	0 comments	Download

Depends on Patchset:

Total messages: 9 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106333003/20001

4 years, 5 months ago (2016-06-30 23:10:11 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-06-30 23:57:07 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/7da94ee9792c09e05911e80d5a2d5266ed547bf4
Cr-Commit-Position: refs/heads/master@{#403352}