Disallow identical names for the Encryption and Crypto-Key headers

components/gcm_driver/crypto/encryption_header_parsers_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/crypto/encryption_header_parsers.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <vector>
@@ skipping 24 matching lines @@
     { " keyid = foo ; salt = c2l4dGVlbmNvb2xieXRlcw ; rs = 1024 ",
       "foo", "sixteencoolbytes", 1024 },
     { "keyid=foo", "foo", "", kDefaultRecordSize },
     { "keyid=foo;", "foo", "", kDefaultRecordSize },
     { "keyid=\"foo\"", "foo", "", kDefaultRecordSize },
     { "keyid='foo'", "foo", "", kDefaultRecordSize },
     { "salt=c2l4dGVlbmNvb2xieXRlcw",
       "", "sixteencoolbytes", kDefaultRecordSize },
     { "rs=2048", "", "", 2048 },
     { "keyid=foo;someothervalue=1;rs=42", "foo", "", 42 },
-    { "keyid=foo;keyid=bar", "bar", "", kDefaultRecordSize },
   };
 
   for (size_t i = 0; i < arraysize(expected_results); i++) {
     SCOPED_TRACE(i);
 
     std::string header(expected_results[i].header);
 
     EncryptionHeaderIterator iterator(header.begin(), header.end());
     ASSERT_TRUE(iterator.GetNext());
 
@@ skipping 53 matching lines @@
   const char* const expected_failures[] = {
     // Values in the name-value pairs are not optional.
     "keyid",
     "keyid=",
     "keyid=foo;keyid",
     "salt",
     "salt=",
     "rs",
     "rs=",
 
+    // Supplying the same name multiple times in the same value is invalid.
+    "keyid=foo;keyid=bar",
+    "keyid=foo;bar=baz;keyid=qux",
+
     // The salt must be a URL-safe base64 decodable string.
     "salt=YmV/2ZXJ-sMDA",
     "salt=dHdlbHZlY29vbGJ5dGVz=====",
     "salt=c2l4dGVlbmNvb2xieXRlcw;salt=123$xyz",
     "salt=123$xyz",
 
     // The record size must be a positive decimal integer greater than one that
     // does not start with a plus.
     "rs=0",
     "rs=0x13",
@@ skipping 51 matching lines @@
       "foo", "sixteencoolbytes", "twelvecoolbytes" },
     { "KEYID=foo;AESGCM128=c2l4dGVlbmNvb2xieXRlcw;DH=dHdlbHZlY29vbGJ5dGVz",
       "foo", "sixteencoolbytes", "twelvecoolbytes" },
     { "keyid=foo", "foo", "", "" },
     { "aesgcm128=c2l4dGVlbmNvb2xieXRlcw", "", "sixteencoolbytes", "" },
     { "aesgcm128=\"c2l4dGVlbmNvb2xieXRlcw\"", "", "sixteencoolbytes", "" },
     { "aesgcm128='c2l4dGVlbmNvb2xieXRlcw'", "", "sixteencoolbytes", "" },
     { "dh=dHdlbHZlY29vbGJ5dGVz", "", "", "twelvecoolbytes" },
     { "keyid=foo;someothervalue=bar;aesgcm128=dHdlbHZlY29vbGJ5dGVz",
       "foo", "twelvecoolbytes", "" },
-    { "keyid=foo;keyid=bar", "bar", "", "" },
   };
 
   for (size_t i = 0; i < arraysize(expected_results); i++) {
     SCOPED_TRACE(i);
 
     std::string header(expected_results[i].header);
 
     CryptoKeyHeaderIterator iterator(header.begin(), header.end());
     ASSERT_TRUE(iterator.GetNext());
 
@@ skipping 54 matching lines @@
   const char* const expected_failures[] = {
     // Values in the name-value pairs are not optional.
     "keyid",
     "keyid=",
     "keyid=foo;keyid",
     "aesgcm128",
     "aesgcm128=",
     "dh",
     "dh=",
 
+    // Supplying the same name multiple times in the same value is invalid.
+    "keyid=foo;keyid=bar",
+    "keyid=foo;bar=baz;keyid=qux",
+
     // The "aesgcm128" parameter must be a URL-safe base64 decodable string.
     "aesgcm128=123$xyz",
     "aesgcm128=foobar;aesgcm128=123$xyz",
 
     // The "dh" parameter must be a URL-safe base64 decodable string.
     "dh=YmV/2ZXJ-sMDA",
     "dh=dHdlbHZlY29vbGJ5dGVz=====",
     "dh=123$xyz",
   };
 
@@ skipping 87 matching lines @@
   ASSERT_FALSE(crypto_key_iterator.GetNext());
 
   EXPECT_EQ(0u, crypto_key_iterator.keyid().size());
   EXPECT_EQ(0u, crypto_key_iterator.aesgcm128().size());
   EXPECT_EQ(0u, crypto_key_iterator.dh().size());
 }
 
 }  // namespace
 
 }  // namespace gcm