Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2106313002: Enable whole-program vtable opt when CFI is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 78c26e391bb6f409c8027c168c1b6dab9f5b045f..0ac0eea297db91a40014e1d5599cf8c10dd5e5a7 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -465,11 +465,8 @@ config("compiler") {
ldflags += [ "-Wl,-plugin-opt,-function-sections" ]
}
- # TODO(pcc): Make these flags work correctly with CFI.
- if (!is_cfi) {
- cflags += [ "-fwhole-program-vtables" ]
- ldflags += [ "-fwhole-program-vtables" ]
- }
+ cflags += [ "-fwhole-program-vtables" ]
+ ldflags += [ "-fwhole-program-vtables" ]
}
# Pass the same C/C++ flags to the objective C/C++ compiler.
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698