Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9378)

Unified Diff: build/common.gypi

Issue 2106313002: Enable whole-program vtable opt when CFI is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f5d107d0dc14f4b865cdaa75c592f66ef5d1ef08..7120836c637e8683adddc516c84a9f7cc9ae7a6e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -6085,6 +6085,12 @@
'arflags': [
'--plugin', '../../<(make_clang_dir)/lib/LLVMgold.so',
],
+ 'cflags': [
+ '-fwhole-program-vtables',
+ ],
+ 'ldflags': [
+ '-fwhole-program-vtables',
+ ],
}],
],
'msvs_settings': {
@@ -6274,21 +6280,6 @@
],
},
}],
- # TODO(pcc): Make these flags work correctly with CFI.
- ['use_lto!=0 and cfi_vptr==0', {
- 'target_defaults': {
- 'target_conditions': [
- ['_toolset=="target"', {
- 'cflags': [
- '-fwhole-program-vtables',
- ],
- 'ldflags': [
- '-fwhole-program-vtables',
- ],
- }],
- ],
- },
- }],
],
'xcode_settings': {
# DON'T ADD ANYTHING NEW TO THIS BLOCK UNLESS YOU REALLY REALLY NEED IT!
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698