Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 2106213002: Ignore favicon request in DataSaverWithServerBrowserTest.ReloadPage (Closed)

Created:
4 years, 5 months ago by Raj
Modified:
4 years, 5 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore favicon request in DataSaverWithServerBrowserTest.ReloadPage Favicon request could be received for the previous page load when data saver was enabled and could contain save-data header, while the test expects no save-data header. BUG=624442 Committed: https://crrev.com/954faf4ed3a27940a2433743917ed86a739026e8 Cr-Commit-Position: refs/heads/master@{#402895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/data_saver/data_saver_browsertest.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Raj
ptal
4 years, 5 months ago (2016-06-29 18:36:13 UTC) #2
tbansal1
lgtm
4 years, 5 months ago (2016-06-29 18:40:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106213002/1
4 years, 5 months ago (2016-06-29 18:44:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 19:28:04 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 19:28:18 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:30:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/954faf4ed3a27940a2433743917ed86a739026e8
Cr-Commit-Position: refs/heads/master@{#402895}

Powered by Google App Engine
This is Rietveld 408576698