Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: chrome/browser/data_saver/data_saver_browsertest.cc

Issue 2106213002: Ignore favicon request in DataSaverWithServerBrowserTest.ReloadPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/data_saver/data_saver_browsertest.cc
diff --git a/chrome/browser/data_saver/data_saver_browsertest.cc b/chrome/browser/data_saver/data_saver_browsertest.cc
index 740db9716504b7e54ef5c3fcfcdee9faab97742d..f5f9aef0b7ba14a8eb33d39eb196c5c0f24695d5 100644
--- a/chrome/browser/data_saver/data_saver_browsertest.cc
+++ b/chrome/browser/data_saver/data_saver_browsertest.cc
@@ -67,11 +67,19 @@ class DataSaverWithServerBrowserTest : public InProcessBrowserTest {
const net::test_server::HttpRequest& request) {
auto save_data_header_it = request.headers.find("save-data");
+ if (request.relative_url == "/favicon.ico") {
+ // Favicon request could be received for the previous page load.
+ return std::unique_ptr<net::test_server::HttpResponse>();
+ }
+
if (!expected_save_data_header_.empty()) {
- EXPECT_TRUE(save_data_header_it != request.headers.end());
- EXPECT_EQ(expected_save_data_header_, save_data_header_it->second);
+ EXPECT_TRUE(save_data_header_it != request.headers.end())
+ << request.relative_url;
+ EXPECT_EQ(expected_save_data_header_, save_data_header_it->second)
+ << request.relative_url;
} else {
- EXPECT_TRUE(save_data_header_it == request.headers.end());
+ EXPECT_TRUE(save_data_header_it == request.headers.end())
+ << request.relative_url;
}
return std::unique_ptr<net::test_server::HttpResponse>();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698