Make it possible to use 'cwd' in api.step.context

Make it possible to use 'cwd' in api.step.context

Needed e.g. for https://codereview.chromium.org/2105873004 .

BUG=chromium:585401, chromium:593999
Committed: https://github.com/luci/recipes-py/commit/7efa94d613f430f85af7f8c8364f85319ee9fa94

[Paweł Hajdan Jr., 2016-06-29 13:38:55]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 13:39:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2016-06-29 13:41:35]

Description was changed from

==========
Make it possible to use 'cwd' in api.step.context

BUG=chromium:585401, chromium:593999
==========

to

==========
Make it possible to use 'cwd' in api.step.context

Needed e.g. for https://codereview.chromium.org/2105873004 .

BUG=chromium:585401, chromium:593999
==========

[commit-bot: I haz the power, 2016-06-29 13:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 13:42:57]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-06-29 13:45:18]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Sergiy Byelozyorov, 2016-06-29 13:56:30]

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py
File recipe_engine/recipe_api.py (right):

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py...
recipe_engine/recipe_api.py:121: 'cwd': {'combine': lambda a, b: b},
This would always return value passed second and never return whatever is in the
compositor... what's the point?

[Paweł Hajdan Jr., 2016-06-29 13:57:57]

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py
File recipe_engine/recipe_api.py (right):

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py...
recipe_engine/recipe_api.py:121: 'cwd': {'combine': lambda a, b: b},
On 2016/06/29 at 13:56:30, Sergiy Byelozyorov wrote:
> This would always return value passed second and never return whatever is in
the compositor... what's the point?

See other entries here which already do this. The meaning of that is to
override/overwrite value in compositor.

[Sergiy Byelozyorov, 2016-06-29 14:00:10]

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py
File recipe_engine/recipe_api.py (right):

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py...
recipe_engine/recipe_api.py:121: 'cwd': {'combine': lambda a, b: b},
On 2016/06/29 13:57:57, Paweł Hajdan Jr. wrote:
> On 2016/06/29 at 13:56:30, Sergiy Byelozyorov wrote:
> > This would always return value passed second and never return whatever is in
> the compositor... what's the point?
> 
> See other entries here which already do this. The meaning of that is to
> override/overwrite value in compositor.

But the point is that it doesn't... it just returns the second value without
ever considering the value in the compositor. And it does not update the value
in the compositor either:
https://cs.chromium.org/chromium/infra/recipes-py/recipe_engine/field_compose....

[Paweł Hajdan Jr., 2016-06-29 14:14:31]

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py
File recipe_engine/recipe_api.py (right):

https://codereview.chromium.org/2106153002/diff/1/recipe_engine/recipe_api.py...
recipe_engine/recipe_api.py:121: 'cwd': {'combine': lambda a, b: b},
On 2016/06/29 at 14:00:10, Sergiy Byelozyorov wrote:
> On 2016/06/29 13:57:57, Paweł Hajdan Jr. wrote:
> > On 2016/06/29 at 13:56:30, Sergiy Byelozyorov wrote:
> > > This would always return value passed second and never return whatever is
in
> > the compositor... what's the point?
> > 
> > See other entries here which already do this. The meaning of that is to
> > override/overwrite value in compositor.
> 
> But the point is that it doesn't... it just returns the second value without
ever considering the value in the compositor. And it does not update the value
in the compositor either:
https://cs.chromium.org/chromium/infra/recipes-py/recipe_engine/field_compose....

While I have to provide a combine function here, I've simplified step recipe
module code based on your suggestion. PTAL.

[Sergiy Byelozyorov, 2016-06-29 14:15:08]

lgtm

[Paweł Hajdan Jr., 2016-06-29 14:16:23]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-06-29 14:16:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 14:18:22]

Description was changed from

==========
Make it possible to use 'cwd' in api.step.context

Needed e.g. for https://codereview.chromium.org/2105873004 .

BUG=chromium:585401, chromium:593999
==========

to

==========
Make it possible to use 'cwd' in api.step.context

Needed e.g. for https://codereview.chromium.org/2105873004 .

BUG=chromium:585401, chromium:593999

Committed:
https://github.com/luci/recipes-py/commit/7efa94d613f430f85af7f8c8364f85319ee...
==========

[commit-bot: I haz the power, 2016-06-29 14:18:23]

Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/7efa94d613f430f85af7f8c8364f85319ee...