Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2105873004: chromium_tests: set cwd to directory containing checkout for tests (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium_tests: set cwd to directory containing checkout for tests Turns out our tests/scripts rely on that, and the directory is different when using remote_run/path_config=kitchen. Depends on https://codereview.chromium.org/2106153002 BUG=chromium:585401, chromium:593999 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d07b1b969d29c51df455b6b7ceeda74555fdd79d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 3 chunks +12 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_remote_run_Tester.json View 5 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paweł Hajdan Jr.
Example failure: https://build.chromium.org/p/chromium.fyi/builders/Linux%20remote_run%20Tester/builds/29/steps/base_unittests/logs/stdio
4 years, 5 months ago (2016-06-29 13:41:24 UTC) #2
Sergiy Byelozyorov
lgtm
4 years, 5 months ago (2016-06-29 13:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105873004/1
4 years, 5 months ago (2016-06-29 14:37:12 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 14:40:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d07b1b969d29c51df455...

Powered by Google App Engine
This is Rietveld 408576698