test/cctest/test-log-stack-tracer.cc - Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-log-stack-tracer.cc

diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc

index 1961377235b262317c7e898518777a3ed1b128b3..e38d74e1bd68993aec479bf5046bc487dd763126 100644

--- a/test/cctest/test-log-stack-tracer.cc

+++ b/test/cctest/test-log-stack-tracer.cc

@@ -79,8 +79,7 @@

static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) {

i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());

i::StackFrameIterator frame_iterator(isolate);

- CHECK(frame_iterator.frame()->is_exit() ||

- frame_iterator.frame()->is_builtin_exit());

+ CHECK(frame_iterator.frame()->is_exit());

frame_iterator.Advance();

CHECK(frame_iterator.frame()->is_construct());

frame_iterator.Advance();

« no previous file with comments | « test/cctest/compiler/test-run-inlining.cc ('k') | test/message/paren_in_arg_string.out » ('j') | no next file with comments »