Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: test/cctest/test-log-stack-tracer.cc

Issue 2106113002: Revert of [builtins] New frame type for exits to C++ builtins (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/compiler/test-run-inlining.cc ('k') | test/message/paren_in_arg_string.out » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 return IsAddressWithinFuncCode(js_func, addr); 72 return IsAddressWithinFuncCode(js_func, addr);
73 } 73 }
74 74
75 75
76 // This C++ function is called as a constructor, to grab the frame pointer 76 // This C++ function is called as a constructor, to grab the frame pointer
77 // from the calling function. When this function runs, the stack contains 77 // from the calling function. When this function runs, the stack contains
78 // a C_Entry frame and a Construct frame above the calling function's frame. 78 // a C_Entry frame and a Construct frame above the calling function's frame.
79 static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) { 79 static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) {
80 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate()); 80 i::Isolate* isolate = reinterpret_cast<i::Isolate*>(args.GetIsolate());
81 i::StackFrameIterator frame_iterator(isolate); 81 i::StackFrameIterator frame_iterator(isolate);
82 CHECK(frame_iterator.frame()->is_exit() || 82 CHECK(frame_iterator.frame()->is_exit());
83 frame_iterator.frame()->is_builtin_exit());
84 frame_iterator.Advance(); 83 frame_iterator.Advance();
85 CHECK(frame_iterator.frame()->is_construct()); 84 CHECK(frame_iterator.frame()->is_construct());
86 frame_iterator.Advance(); 85 frame_iterator.Advance();
87 if (i::FLAG_ignition) { 86 if (i::FLAG_ignition) {
88 // Skip over bytecode handler frame. 87 // Skip over bytecode handler frame.
89 CHECK(frame_iterator.frame()->type() == i::StackFrame::STUB); 88 CHECK(frame_iterator.frame()->type() == i::StackFrame::STUB);
90 frame_iterator.Advance(); 89 frame_iterator.Advance();
91 } 90 }
92 i::StackFrame* calling_frame = frame_iterator.frame(); 91 i::StackFrame* calling_frame = frame_iterator.frame();
93 CHECK(calling_frame->is_java_script()); 92 CHECK(calling_frame->is_java_script());
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION); 291 v8::Local<v8::Context> context = CcTest::NewContext(TRACE_EXTENSION);
293 v8::Context::Scope context_scope(context); 292 v8::Context::Scope context_scope(context);
294 CHECK(!i::TraceExtension::GetJsEntrySp()); 293 CHECK(!i::TraceExtension::GetJsEntrySp());
295 CompileRun("a = 1; b = a + 1;"); 294 CompileRun("a = 1; b = a + 1;");
296 CHECK(!i::TraceExtension::GetJsEntrySp()); 295 CHECK(!i::TraceExtension::GetJsEntrySp());
297 CompileRun("js_entry_sp();"); 296 CompileRun("js_entry_sp();");
298 CHECK(!i::TraceExtension::GetJsEntrySp()); 297 CHECK(!i::TraceExtension::GetJsEntrySp());
299 CompileRun("js_entry_sp_level2();"); 298 CompileRun("js_entry_sp_level2();");
300 CHECK(!i::TraceExtension::GetJsEntrySp()); 299 CHECK(!i::TraceExtension::GetJsEntrySp());
301 } 300 }
OLDNEW
« no previous file with comments | « test/cctest/compiler/test-run-inlining.cc ('k') | test/message/paren_in_arg_string.out » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698