Revert of Pass initial size and GPU preference via context attributes

Revert of Pass initial size and GPU preference via context attributes (patchset #4 id:60001 of https://codereview.chromium.org/2107783003/ )

Reason for revert:
Sheriff reverting under suspicion of causing a Win8 build break.  It seems to be in gles2, and none of the other changelists changed gles2

Build break logs here:
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/builds/167

Relevant parts of logs:
FAILED: gles2_utils.dll gles2_utils.dll.lib gles2_utils.dll.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True gles2_utils.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:gles2_utils.dll.lib /DLL /OUT:gles2_utils.dll @gles2_utils.dll.rsp" 2 mt.exe rc.exe "obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.intermediate.manifest" obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.generated.manifest
gles2_utils.gles2_cmd_utils.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall gfx::Size::Size(void)" (__imp_??0Size@gfx@@QAE@XZ) referenced in function "public: __thiscall gpu::gles2::ContextCreationAttribHelper::ContextCreationAttribHelper(void)" (??0ContextCreationAttribHelper@gles2@gpu@@QAE@XZ)

gles2_utils.dll : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Pass initial offscreen size and GPU preference via context attributes
>
> This makes client code simpler, because all those things are passed through the same places.
>
> This CL also cleans up a few things:
> 1- make (0, 0) a valid size for offscreen contexts more generally. It is already the case for GPU process contexts (CommandBufferProxyImpl), make it valid for the other types (GLInProcessContext, tests) by handling the logic it in GLES2DecoderImpl. This will also allow us to later remove allocating unneeded textures.
> 2- many callers were setting an arbitrary dummy size, even for onscreen contexts (where it's not used), or when the default framebuffer isn't used (most contexts except Pepper and EGL).
> 3- many callers were arbitrarily choosing the discrete GPU, when it doesn't matter (android, tests), whereas most of the code (compositor, helper contexts) should be choosing the integrated one, for consistency. In particular, pixel tests should be consistent with production.
>
> BUG=None
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/11f4e35b660f4f5cbaed65a0a7f181b8426e877e
> Cr-Commit-Position: refs/heads/master@{#402955}

TBR=sievers@chromium.org,fsamuel@chromium.org,sky@chromium.org,wez@chromium.org,boliu@chromium.org,dcheng@chromium.org,danakj@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Committed: https://crrev.com/fa5a4e6901537131f49acd3f6d4a2016d11bfd61
Cr-Commit-Position: refs/heads/master@{#402989}

[Pete Williamson, 2016-06-29 23:18:14]

The CQ bit was checked by petewil@chromium.org

[Pete Williamson, 2016-06-29 23:18:15]

Created Revert of Pass initial size and GPU preference via context attributes

[commit-bot: I haz the power, 2016-06-29 23:20:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:34:03]

Description was changed from

==========
Revert of Pass initial size and GPU preference via context attributes (patchset
#4 id:60001 of https://codereview.chromium.org/2107783003/ )

Reason for revert:
Sheriff reverting under suspicion of causing a Win8 build break.  It seems to be
in gles2, and none of the other changelists changed gles2

Build break logs here:
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...

Relevant parts of logs:
FAILED: gles2_utils.dll gles2_utils.dll.lib gles2_utils.dll.pdb 
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x86 True gles2_utils.dll "E:\b\depot_tools\python276_bin\python.exe
gyp-win-tool link-wrapper environment.x86 False link.exe /nologo
/IMPLIB:gles2_utils.dll.lib /DLL /OUT:gles2_utils.dll @gles2_utils.dll.rsp" 2
mt.exe rc.exe
"obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.intermediate.manifest"
obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.generated.manifest
gles2_utils.gles2_cmd_utils.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: __thiscall gfx::Size::Size(void)"
(__imp_??0Size@gfx@@QAE@XZ) referenced in function "public: __thiscall
gpu::gles2::ContextCreationAttribHelper::ContextCreationAttribHelper(void)"
(??0ContextCreationAttribHelper@gles2@gpu@@QAE@XZ)

gles2_utils.dll : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Pass initial offscreen size and GPU preference via context attributes
> 
> This makes client code simpler, because all those things are passed through
the same places.
> 
> This CL also cleans up a few things:
> 1- make (0, 0) a valid size for offscreen contexts more generally. It is
already the case for GPU process contexts (CommandBufferProxyImpl), make it
valid for the other types (GLInProcessContext, tests) by handling the logic it
in GLES2DecoderImpl. This will also allow us to later remove allocating unneeded
textures.
> 2- many callers were setting an arbitrary dummy size, even for onscreen
contexts (where it's not used), or when the default framebuffer isn't used (most
contexts except Pepper and EGL).
> 3- many callers were arbitrarily choosing the discrete GPU, when it doesn't
matter (android, tests), whereas most of the code (compositor, helper contexts)
should be choosing the integrated one, for consistency. In particular, pixel
tests should be consistent with production.
> 
> BUG=None
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/11f4e35b660f4f5cbaed65a0a7f181b8426e877e
> Cr-Commit-Position: refs/heads/master@{#402955}

TBR=sievers@chromium.org,fsamuel@chromium.org,sky@chromium.org,wez@chromium.o...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
==========

to

==========
Revert of Pass initial size and GPU preference via context attributes (patchset
#4 id:60001 of https://codereview.chromium.org/2107783003/ )

Reason for revert:
Sheriff reverting under suspicion of causing a Win8 build break.  It seems to be
in gles2, and none of the other changelists changed gles2

Build break logs here:
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...

Relevant parts of logs:
FAILED: gles2_utils.dll gles2_utils.dll.lib gles2_utils.dll.pdb 
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x86 True gles2_utils.dll "E:\b\depot_tools\python276_bin\python.exe
gyp-win-tool link-wrapper environment.x86 False link.exe /nologo
/IMPLIB:gles2_utils.dll.lib /DLL /OUT:gles2_utils.dll @gles2_utils.dll.rsp" 2
mt.exe rc.exe
"obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.intermediate.manifest"
obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.generated.manifest
gles2_utils.gles2_cmd_utils.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: __thiscall gfx::Size::Size(void)"
(__imp_??0Size@gfx@@QAE@XZ) referenced in function "public: __thiscall
gpu::gles2::ContextCreationAttribHelper::ContextCreationAttribHelper(void)"
(??0ContextCreationAttribHelper@gles2@gpu@@QAE@XZ)

gles2_utils.dll : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Pass initial offscreen size and GPU preference via context attributes
> 
> This makes client code simpler, because all those things are passed through
the same places.
> 
> This CL also cleans up a few things:
> 1- make (0, 0) a valid size for offscreen contexts more generally. It is
already the case for GPU process contexts (CommandBufferProxyImpl), make it
valid for the other types (GLInProcessContext, tests) by handling the logic it
in GLES2DecoderImpl. This will also allow us to later remove allocating unneeded
textures.
> 2- many callers were setting an arbitrary dummy size, even for onscreen
contexts (where it's not used), or when the default framebuffer isn't used (most
contexts except Pepper and EGL).
> 3- many callers were arbitrarily choosing the discrete GPU, when it doesn't
matter (android, tests), whereas most of the code (compositor, helper contexts)
should be choosing the integrated one, for consistency. In particular, pixel
tests should be consistent with production.
> 
> BUG=None
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/11f4e35b660f4f5cbaed65a0a7f181b8426e877e
> Cr-Commit-Position: refs/heads/master@{#402955}

TBR=sievers@chromium.org,fsamuel@chromium.org,sky@chromium.org,wez@chromium.o...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
==========

[commit-bot: I haz the power, 2016-06-29 23:34:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 23:34:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 23:35:59]

Description was changed from

==========
Revert of Pass initial size and GPU preference via context attributes (patchset
#4 id:60001 of https://codereview.chromium.org/2107783003/ )

Reason for revert:
Sheriff reverting under suspicion of causing a Win8 build break.  It seems to be
in gles2, and none of the other changelists changed gles2

Build break logs here:
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...

Relevant parts of logs:
FAILED: gles2_utils.dll gles2_utils.dll.lib gles2_utils.dll.pdb 
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x86 True gles2_utils.dll "E:\b\depot_tools\python276_bin\python.exe
gyp-win-tool link-wrapper environment.x86 False link.exe /nologo
/IMPLIB:gles2_utils.dll.lib /DLL /OUT:gles2_utils.dll @gles2_utils.dll.rsp" 2
mt.exe rc.exe
"obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.intermediate.manifest"
obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.generated.manifest
gles2_utils.gles2_cmd_utils.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: __thiscall gfx::Size::Size(void)"
(__imp_??0Size@gfx@@QAE@XZ) referenced in function "public: __thiscall
gpu::gles2::ContextCreationAttribHelper::ContextCreationAttribHelper(void)"
(??0ContextCreationAttribHelper@gles2@gpu@@QAE@XZ)

gles2_utils.dll : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Pass initial offscreen size and GPU preference via context attributes
> 
> This makes client code simpler, because all those things are passed through
the same places.
> 
> This CL also cleans up a few things:
> 1- make (0, 0) a valid size for offscreen contexts more generally. It is
already the case for GPU process contexts (CommandBufferProxyImpl), make it
valid for the other types (GLInProcessContext, tests) by handling the logic it
in GLES2DecoderImpl. This will also allow us to later remove allocating unneeded
textures.
> 2- many callers were setting an arbitrary dummy size, even for onscreen
contexts (where it's not used), or when the default framebuffer isn't used (most
contexts except Pepper and EGL).
> 3- many callers were arbitrarily choosing the discrete GPU, when it doesn't
matter (android, tests), whereas most of the code (compositor, helper contexts)
should be choosing the integrated one, for consistency. In particular, pixel
tests should be consistent with production.
> 
> BUG=None
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> 
> Committed: https://crrev.com/11f4e35b660f4f5cbaed65a0a7f181b8426e877e
> Cr-Commit-Position: refs/heads/master@{#402955}

TBR=sievers@chromium.org,fsamuel@chromium.org,sky@chromium.org,wez@chromium.o...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
==========

to

==========
Revert of Pass initial size and GPU preference via context attributes (patchset
#4 id:60001 of https://codereview.chromium.org/2107783003/ )

Reason for revert:
Sheriff reverting under suspicion of causing a Win8 build break.  It seems to be
in gles2, and none of the other changelists changed gles2

Build break logs here:
https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui...

Relevant parts of logs:
FAILED: gles2_utils.dll gles2_utils.dll.lib gles2_utils.dll.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x86 True gles2_utils.dll "E:\b\depot_tools\python276_bin\python.exe
gyp-win-tool link-wrapper environment.x86 False link.exe /nologo
/IMPLIB:gles2_utils.dll.lib /DLL /OUT:gles2_utils.dll @gles2_utils.dll.rsp" 2
mt.exe rc.exe
"obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.intermediate.manifest"
obj\gpu\command_buffer\gles2_utils.gles2_utils.dll.generated.manifest
gles2_utils.gles2_cmd_utils.obj : error LNK2019: unresolved external symbol
"__declspec(dllimport) public: __thiscall gfx::Size::Size(void)"
(__imp_??0Size@gfx@@QAE@XZ) referenced in function "public: __thiscall
gpu::gles2::ContextCreationAttribHelper::ContextCreationAttribHelper(void)"
(??0ContextCreationAttribHelper@gles2@gpu@@QAE@XZ)

gles2_utils.dll : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Pass initial offscreen size and GPU preference via context attributes
>
> This makes client code simpler, because all those things are passed through
the same places.
>
> This CL also cleans up a few things:
> 1- make (0, 0) a valid size for offscreen contexts more generally. It is
already the case for GPU process contexts (CommandBufferProxyImpl), make it
valid for the other types (GLInProcessContext, tests) by handling the logic it
in GLES2DecoderImpl. This will also allow us to later remove allocating unneeded
textures.
> 2- many callers were setting an arbitrary dummy size, even for onscreen
contexts (where it's not used), or when the default framebuffer isn't used (most
contexts except Pepper and EGL).
> 3- many callers were arbitrarily choosing the discrete GPU, when it doesn't
matter (android, tests), whereas most of the code (compositor, helper contexts)
should be choosing the integrated one, for consistency. In particular, pixel
tests should be consistent with production.
>
> BUG=None
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/11f4e35b660f4f5cbaed65a0a7f181b8426e877e
> Cr-Commit-Position: refs/heads/master@{#402955}

TBR=sievers@chromium.org,fsamuel@chromium.org,sky@chromium.org,wez@chromium.o...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Committed: https://crrev.com/fa5a4e6901537131f49acd3f6d4a2016d11bfd61
Cr-Commit-Position: refs/heads/master@{#402989}
==========

[commit-bot: I haz the power, 2016-06-29 23:36:01]

Patchset 1 (id:??) landed as
https://crrev.com/fa5a4e6901537131f49acd3f6d4a2016d11bfd61
Cr-Commit-Position: refs/heads/master@{#402989}