Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: test/cctest/test-profile-generator.cc

Issue 2105943002: Expose TickSample and its APIs in v8-profiler.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase & address comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc b/test/cctest/test-profile-generator.cc
index 7e59839414dc711ffffeb0290e47124773f78f5a..1885b13b036e528ed06152e6573141bc2e452e3c 100644
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -43,7 +43,7 @@ using i::CpuProfilesCollection;
using i::ProfileNode;
using i::ProfileTree;
using i::ProfileGenerator;
-using i::TickSample;
+using v8::TickSample;
alph 2016/06/29 19:39:09 sort it?
lpy 2016/06/29 20:17:39 Done.
using i::Vector;
@@ -364,7 +364,7 @@ TEST(RecordTickSample) {
sample1.tos = ToAddress(0x1500);
sample1.stack[0] = ToAddress(0x1510);
sample1.frames_count = 1;
- generator.RecordTickSample(sample1);
+ generator.RecordTickSample(sample1, v8::base::TimeTicks::HighResolutionNow());
TickSample sample2;
sample2.pc = ToAddress(0x1925);
sample2.tos = ToAddress(0x1900);
@@ -372,14 +372,14 @@ TEST(RecordTickSample) {
sample2.stack[1] = ToAddress(0x10000); // non-existent.
sample2.stack[2] = ToAddress(0x1620);
sample2.frames_count = 3;
- generator.RecordTickSample(sample2);
+ generator.RecordTickSample(sample2, v8::base::TimeTicks::HighResolutionNow());
TickSample sample3;
sample3.pc = ToAddress(0x1510);
sample3.tos = ToAddress(0x1500);
sample3.stack[0] = ToAddress(0x1910);
sample3.stack[1] = ToAddress(0x1610);
sample3.frames_count = 2;
- generator.RecordTickSample(sample3);
+ generator.RecordTickSample(sample3, v8::base::TimeTicks::HighResolutionNow());
CpuProfile* profile = profiles.StopProfiling("");
CHECK(profile);
@@ -431,26 +431,23 @@ TEST(SampleIds) {
// (root)#1 -> aaa #2 -> bbb #4 -> ccc #5 - sample2
// -> ccc #6 -> aaa #7 - sample3
TickSample sample1;
- sample1.timestamp = v8::base::TimeTicks::HighResolutionNow();
sample1.pc = ToAddress(0x1600);
sample1.stack[0] = ToAddress(0x1510);
sample1.frames_count = 1;
- generator.RecordTickSample(sample1);
+ generator.RecordTickSample(sample1, v8::base::TimeTicks::HighResolutionNow());
TickSample sample2;
- sample2.timestamp = v8::base::TimeTicks::HighResolutionNow();
sample2.pc = ToAddress(0x1925);
sample2.stack[0] = ToAddress(0x1780);
sample2.stack[1] = ToAddress(0x10000); // non-existent.
sample2.stack[2] = ToAddress(0x1620);
sample2.frames_count = 3;
- generator.RecordTickSample(sample2);
+ generator.RecordTickSample(sample2, v8::base::TimeTicks::HighResolutionNow());
TickSample sample3;
- sample3.timestamp = v8::base::TimeTicks::HighResolutionNow();
sample3.pc = ToAddress(0x1510);
sample3.stack[0] = ToAddress(0x1910);
sample3.stack[1] = ToAddress(0x1610);
sample3.frames_count = 2;
- generator.RecordTickSample(sample3);
+ generator.RecordTickSample(sample3, v8::base::TimeTicks::HighResolutionNow());
CpuProfile* profile = profiles.StopProfiling("");
unsigned nodeId = 1;
@@ -484,7 +481,7 @@ TEST(NoSamples) {
sample1.pc = ToAddress(0x1600);
sample1.stack[0] = ToAddress(0x1510);
sample1.frames_count = 1;
- generator.RecordTickSample(sample1);
+ generator.RecordTickSample(sample1, v8::base::TimeTicks::HighResolutionNow());
CpuProfile* profile = profiles.StopProfiling("");
unsigned nodeId = 1;

Powered by Google App Engine
This is Rietveld 408576698