Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 2105943002: Expose TickSample and its APIs in v8-profiler.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase & address comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc
index e38d74e1bd68993aec479bf5046bc487dd763126..044a2e7c74f0a8d05255c649b8ebef5b82e8cf2e 100644
--- a/test/cctest/test-log-stack-tracer.cc
+++ b/test/cctest/test-log-stack-tracer.cc
@@ -29,14 +29,13 @@
#include <stdlib.h>
-#include "src/v8.h"
-
+#include "include/v8-profiler.h"
#include "src/api.h"
#include "src/codegen.h"
#include "src/disassembler.h"
#include "src/isolate.h"
#include "src/log.h"
-#include "src/profiler/tick-sample.h"
+#include "src/v8.h"
#include "src/vm-state-inl.h"
#include "test/cctest/cctest.h"
#include "test/cctest/trace-extension.h"
@@ -46,6 +45,7 @@ using v8::Local;
using v8::Object;
using v8::Script;
using v8::String;
+using v8::TickSample;
using v8::Value;
using v8::internal::byte;
@@ -53,18 +53,15 @@ using v8::internal::Address;
using v8::internal::Handle;
using v8::internal::Isolate;
using v8::internal::JSFunction;
-using v8::internal::TickSample;
-
-static bool IsAddressWithinFuncCode(JSFunction* function, Address addr) {
+static bool IsAddressWithinFuncCode(JSFunction* function, void* addr) {
+ Address address = reinterpret_cast<Address>(addr);
i::AbstractCode* code = function->abstract_code();
- return code->contains(addr);
+ return code->contains(address);
}
-
static bool IsAddressWithinFuncCode(v8::Local<v8::Context> context,
- const char* func_name,
- Address addr) {
+ const char* func_name, void* addr) {
v8::Local<v8::Value> func =
context->Global()->Get(context, v8_str(func_name)).ToLocalChecked();
CHECK(func->IsFunction());

Powered by Google App Engine
This is Rietveld 408576698