Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2105903003: Remove error handling from MipmapUtil and add DCHECKs (Closed)

Created:
4 years, 5 months ago by ericrk
Modified:
4 years, 5 months ago
Reviewers:
cblume, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fixdrt
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove error handling from MipmapUtil and add DCHECKs MipmapUtil had error handling where it would return "-1" values to indicate errors. None of the call sites should trigger this behavior, so the error checks were converted to DCHECKs. R=vmpstr CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7be6ed953dbcbc459daf863bea02ce254df1321c Cr-Commit-Position: refs/heads/master@{#403285}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -48 lines) Patch
M cc/tiles/mipmap_util.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
M cc/tiles/mipmap_util.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M cc/tiles/mipmap_util_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105903003/1
4 years, 5 months ago (2016-06-30 00:00:55 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/29208) ios-simulator-gn on ...
4 years, 5 months ago (2016-06-30 00:09:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105903003/20001
4 years, 5 months ago (2016-06-30 19:03:50 UTC) #9
ericrk
4 years, 5 months ago (2016-06-30 19:04:26 UTC) #11
cblume
I agree 100% with this. lgtm
4 years, 5 months ago (2016-06-30 20:10:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105903003/20001
4 years, 5 months ago (2016-06-30 20:26:37 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 21:12:11 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 21:12:17 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:14:41 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7be6ed953dbcbc459daf863bea02ce254df1321c
Cr-Commit-Position: refs/heads/master@{#403285}

Powered by Google App Engine
This is Rietveld 408576698