Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3567)

Unified Diff: cc/tiles/mipmap_util_unittest.cc

Issue 2105903003: Remove error handling from MipmapUtil and add DCHECKs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixdrt
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/tiles/mipmap_util.cc ('k') | cc/tiles/software_image_decode_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/mipmap_util_unittest.cc
diff --git a/cc/tiles/mipmap_util_unittest.cc b/cc/tiles/mipmap_util_unittest.cc
index 327c3b98c9f29bb11d8b30bef07aee4250a920a5..ff1819c82f3fa0ba55e52a75b25b27b5d55217e9 100644
--- a/cc/tiles/mipmap_util_unittest.cc
+++ b/cc/tiles/mipmap_util_unittest.cc
@@ -116,34 +116,5 @@ TEST(MipMapUtilTest, Rounding) {
MipMapUtil::GetScaleAdjustmentForSize(src_size, target_size_smaller));
}
-// Ensures that we return invalid values correctly.
-TEST(MipMapUtilTest, Invalid) {
- const gfx::Size valid_size(1024, 1024);
- const gfx::Size invalid_size(0, 1024);
- const gfx::Size invalid_result_size(-1, -1);
- const SkSize invalid_float_result_size = SkSize::Make(-1, -1);
- const int invalid_result_level = -1;
-
- EXPECT_EQ(invalid_result_level,
- MipMapUtil::GetLevelForSize(valid_size, invalid_size));
- EXPECT_EQ(invalid_result_level,
- MipMapUtil::GetLevelForSize(invalid_size, valid_size));
- EXPECT_FLOAT_SIZE_EQ(
- invalid_float_result_size,
- MipMapUtil::GetScaleAdjustmentForSize(valid_size, invalid_size));
- EXPECT_FLOAT_SIZE_EQ(
- invalid_float_result_size,
- MipMapUtil::GetScaleAdjustmentForSize(invalid_size, valid_size));
- EXPECT_SIZE_EQ(invalid_result_size,
- MipMapUtil::GetSizeForLevel(valid_size, invalid_result_level));
- EXPECT_SIZE_EQ(invalid_result_size,
- MipMapUtil::GetSizeForLevel(invalid_size, 0));
- EXPECT_FLOAT_SIZE_EQ(invalid_float_result_size,
- MipMapUtil::GetScaleAdjustmentForLevel(invalid_size, 0));
- EXPECT_FLOAT_SIZE_EQ(
- invalid_float_result_size,
- MipMapUtil::GetScaleAdjustmentForLevel(valid_size, invalid_result_level));
-}
-
} // namespace
} // namespace cc
« no previous file with comments | « cc/tiles/mipmap_util.cc ('k') | cc/tiles/software_image_decode_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698