Updating SystemUI visibility events in Adroid Client.

Updating SystemUI visibility events in Android Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633
Committed: https://crrev.com/cc96f13a7997a739acfc693e33f1247362dea4cd
Cr-Commit-Position: refs/heads/master@{#403253}

[joedow, 2016-06-28 20:44:52]

Description was changed from

==========
Updating SystemUI visibility events in Adroid Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

I also fixed up one calculation for Touch mode where the bounds we were
using to constrain the viewport were not taking System UI into account.
This does not change any user perciptible behavior but should prevent
future issues.

BUG=621633
==========

to

==========
Updating SystemUI visibility events in Adroid Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633
==========

[joedow, 2016-06-28 21:12:13]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2016-06-28 21:12:14]

This is the first change needed to allow for scrolling the remote desktop canvas
out from under any obscurring System UI.

This change updates the soft input method visible event to include general
information about all of the system UI elements on screen.  It also moves some
viewport positioning logic out of the TouchInputHandler and into the
DesktopCanvas class which is where I will add the rest of the scrolling logic in
my next CL.

PTAL!

Thanks,
Joe

[joedow, 2016-06-29 16:01:42]

Ping!

[Lambros, 2016-06-29 20:43:37]

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:375: return
((getWindow().getDecorView().getSystemUiVisibility() & getFullscreenFlags()) ==
0);
Remove outermost parentheses.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
(right):

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:35: private
Rect mSystemUiOffsetPx = new Rect();
Pixels instead of Px?

Is Rect the right choice here? These 4 offset values don't form a rectangle in
the usual way. Perhaps Rect might do something weird, like swap left/right to
keep width positive?

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:61:
viewportCenter.set(viewportCenter.x + deltaX, viewportCenter.y + deltaY);
viewportCenter.offset(deltaX, deltaY);

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:89:
adjustedScreenWidth = mRenderData.screenWidth - mSystemUiOffsetPx.right;
Need to subtract left as well as right?

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:90:
adjustedScreenHeight = mRenderData.screenHeight - mSystemUiOffsetPx.bottom;
top as well as bottom?

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:104: //
Find the center point of the viewport on the screen.
Please add blank line above comment.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:106: //
Convert the screen position to an image position.
and here.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:180: float
rightDelta = rectScreen.right - mRenderData.screenWidth +
mSystemUiOffsetPx.right;
Same here? It looks like you never use mSystemUiOffsetPx.{left or top} anywhere.

[joedow, 2016-06-29 21:08:49]

Description was changed from

==========
Updating SystemUI visibility events in Adroid Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633
==========

to

==========
Updating SystemUI visibility events in Android Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633
==========

[joedow, 2016-06-30 16:03:26]

Addressed CR Feedback, PTAL!

Thanks!

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:375: return
((getWindow().getDecorView().getSystemUiVisibility() & getFullscreenFlags()) ==
0);
On 2016/06/29 20:43:36, Lambros wrote:
> Remove outermost parentheses.

Done.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
(right):

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:35: private
Rect mSystemUiOffsetPx = new Rect();
On 2016/06/29 20:43:37, Lambros wrote:
> Pixels instead of Px?
> 
> Is Rect the right choice here? These 4 offset values don't form a rectangle in
> the usual way. Perhaps Rect might do something weird, like swap left/right to
> keep width positive?

Updated the name.  Rect/RectF doesn't require the values to form a rectangle,
however some of its methods do (i.e. width() or height()).  As long as the data
is treated like a struct with nicely named accessors then it should be fine.

I can also add a private class which has the LTRB getters if you'd prefer.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:61:
viewportCenter.set(viewportCenter.x + deltaX, viewportCenter.y + deltaY);
On 2016/06/29 20:43:37, Lambros wrote:
> viewportCenter.offset(deltaX, deltaY);
> 

Good call.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:89:
adjustedScreenWidth = mRenderData.screenWidth - mSystemUiOffsetPx.right;
On 2016/06/29 20:43:36, Lambros wrote:
> Need to subtract left as well as right?

Not for this CL.  I am not changing previous behavior yet, I just wanted to get
the plumbing done to reduce the size of the next CL where I will be changing
user-facing behavior.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:90:
adjustedScreenHeight = mRenderData.screenHeight - mSystemUiOffsetPx.bottom;
On 2016/06/29 20:43:37, Lambros wrote:
> top as well as bottom?

Next CL as needed.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:104: //
Find the center point of the viewport on the screen.
On 2016/06/29 20:43:36, Lambros wrote:
> Please add blank line above comment.

Done.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:106: //
Convert the screen position to an image position.
On 2016/06/29 20:43:37, Lambros wrote:
> and here.

Done.

https://codereview.chromium.org/2105843002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:180: float
rightDelta = rectScreen.right - mRenderData.screenWidth +
mSystemUiOffsetPx.right;
On 2016/06/29 20:43:37, Lambros wrote:
> Same here? It looks like you never use mSystemUiOffsetPx.{left or top}
anywhere.

Not yet, they are needed in the next CL.

[Lambros, 2016-06-30 18:01:27]

lgtm

[joedow, 2016-06-30 19:07:03]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-06-30 19:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 19:40:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-30 19:43:26]

Description was changed from

==========
Updating SystemUI visibility events in Android Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633
==========

to

==========
Updating SystemUI visibility events in Android Client.

This change is the basis for an upcoming change which will allow the
user to scroll the remote desktop canvas out from under System UI which
would otherwise obscure it.

This change has two main pieces:
1.) I change the 'soft input mode visible' event into a more generic
System UI visible event.  This event will now be used to inform
interested listeners what the offsets are for the LTRB sides of the
screen so the underlying UI can react accordingly.

2.) This change moves some viewport calculation code into the
DesktopCanvas class.  The DesktopCanvas class is aware of the SystemUI
offsets and also handles positioning the canvas so this felt like the
right place to add in the UI ratcheting code later on.

BUG=621633

Committed: https://crrev.com/cc96f13a7997a739acfc693e33f1247362dea4cd
Cr-Commit-Position: refs/heads/master@{#403253}
==========

[commit-bot: I haz the power, 2016-06-30 19:43:27]

Patchset 5 (id:??) landed as
https://crrev.com/cc96f13a7997a739acfc693e33f1247362dea4cd
Cr-Commit-Position: refs/heads/master@{#403253}