third_party/WebKit/Source/web/AssociatedURLLoader.cpp - Issue 2105713002: Render process changes for ResourceTiming sizes.

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

Issue 2105713002: Render process changes for ResourceTiming sizes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@resource_timing_sizes_browser_process

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/network/ResourceResponse.h ('K') | « third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc ('k') | third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp » ('j') | third_party/WebKit/public/platform/WebURLLoaderClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/AssociatedURLLoader.cpp

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

index a740f026f7a04fa89997ad82c336fe348033104c..9d0c68a123fa3d0cf5047b2f10065c3954b21729 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

+++ b/third_party/WebKit/Source/web/AssociatedURLLoader.cpp

@@ -149,7 +149,8 @@ void AssociatedURLLoader::ClientAdapter::willFollowRedirect(ResourceRequest& new

WrappedResourceRequest wrappedNewRequest(newRequest);

WrappedResourceResponse wrappedRedirectResponse(redirectResponse);

- m_client->willFollowRedirect(m_loader, wrappedNewRequest, wrappedRedirectResponse);

+ // FIXME: Set encodedDataLength

kinuko 2016/06/28 15:35:08 Are you going to plumb this too? Do we need to pr

Adam Rice 2016/06/29 09:52:15 I'm not sure whether it is actually needed. I have

+ m_client->willFollowRedirect(m_loader, wrappedNewRequest, wrappedRedirectResponse, 0);

}

void AssociatedURLLoader::ClientAdapter::didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent)

@@ -208,7 +209,7 @@ void AssociatedURLLoader::ClientAdapter::didReceiveData(const char* data, unsign

CHECK_LE(dataLength, static_cast<unsigned>(std::numeric_limits<int>::max()));

- m_client->didReceiveData(m_loader, data, dataLength, -1);

+ m_client->didReceiveData(m_loader, data, dataLength, -1, dataLength);

kinuko 2016/06/28 15:35:08 In this case we might be adding up -1 to the respo

Adam Rice 2016/06/29 09:52:15 It gets added to the encodedDataSize, but it is a

}

void AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata(const char* data, int dataLength)