Render process changes for ResourceTiming sizes.

third_party/WebKit/Source/web/AssociatedURLLoader.cpp

 /*
  * Copyright (C) 2010, 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 131 matching lines @@
     DCHECK(m_client);
 }
 
 void AssociatedURLLoader::ClientAdapter::willFollowRedirect(ResourceRequest& newRequest, const ResourceResponse& redirectResponse)
 {
     if (!m_client)
         return;
 
     WrappedResourceRequest wrappedNewRequest(newRequest);
     WrappedResourceResponse wrappedRedirectResponse(redirectResponse);
-    m_client->willFollowRedirect(m_loader, wrappedNewRequest, wrappedRedirectResponse);
+    // FIXME: Set encodedDataLength

[kinuko, 2016/06/28 15:35:08]

Are you going to plumb this too?  Do we need to propagate values via
Resource::willFollowRedirect?

[Adam Rice, 2016/06/29 09:52:15]

I'm not sure whether it is actually needed. I haven't worked out what
AssociatedURLLoader is used for yet.

+    m_client->willFollowRedirect(m_loader, wrappedNewRequest, wrappedRedirectResponse, 0);
 }
 
 void AssociatedURLLoader::ClientAdapter::didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent)
 {
     if (!m_client)
         return;
 
     m_client->didSendData(m_loader, bytesSent, totalBytesToBeSent);
 }
 
@@ skipping 38 matching lines @@
     m_client->didDownloadData(m_loader, dataLength, -1);
 }
 
 void AssociatedURLLoader::ClientAdapter::didReceiveData(const char* data, unsigned dataLength)
 {
     if (!m_client)
         return;
 
     CHECK_LE(dataLength, static_cast<unsigned>(std::numeric_limits<int>::max()));
 
-    m_client->didReceiveData(m_loader, data, dataLength, -1);
+    m_client->didReceiveData(m_loader, data, dataLength, -1, dataLength);

[kinuko, 2016/06/28 15:35:08]

In this case we might be adding up -1 to the responseBodySize (==
decodedBodySize)?

[Adam Rice, 2016/06/29 09:52:15]

It gets added to the encodedDataSize, but it is a problem. I tried putting a
CHECK in ResourceTimingInfo and running the layout tests and found many other
places where -1 is passed. Fortunately they don't seem to be common cases, so I
think it is acceptable for the purposes of this CL. I added a check in
ResourceFetcher to convert -1 to 0 before passing to ResourceTimingInfo and a
FIXME to chase down the cases where the value should be set but isn't.

 }
 
 void AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata(const char* data, int dataLength)
 {
     if (!m_client)
         return;
 
     m_client->didReceiveCachedMetadata(m_loader, data, dataLength);
 }
 
@@ skipping 229 matching lines @@
     // there could be a WebURLLoader instance behind the
     // DocumentThreadableLoader instance. So, for safety, we chose to just
     // crash here.
     RELEASE_ASSERT(ThreadState::current());
 
     m_observer->dispose();
     m_observer = nullptr;
 }
 
 } // namespace blink