Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2105653004: Remove redundant isInline function (Closed)

Created:
4 years, 5 months ago by joone
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant isInline function The same isInline function is defined in EditingUtilities.cpp and IndentOutdentCommand.cpp. This CL adds isInline declaration in EditingUtilities.h so that it can remove the same function from IndentOutdentCommand.cpp. In addition, it uses Node::computedStyle() rather than layout object to reduce dependency of layout tree. BUG=none Committed: https://crrev.com/8f100f366a988f30442a19fd4909815c36f9df9c Cr-Commit-Position: refs/heads/master@{#402689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
joone
Hi yosin@ could you review this CL?
4 years, 5 months ago (2016-06-29 00:54:35 UTC) #3
yosin_UTC9
lgtm Good catch! Thanks for cleanup!
4 years, 5 months ago (2016-06-29 00:57:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105653004/1
4 years, 5 months ago (2016-06-29 00:58:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:42:02 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:45:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f100f366a988f30442a19fd4909815c36f9df9c
Cr-Commit-Position: refs/heads/master@{#402689}

Powered by Google App Engine
This is Rietveld 408576698