third_party/WebKit/Source/core/editing/EditingUtilities.cpp - Issue 2105653004: Remove redundant isInline function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2105653004: Remove redundant isInline function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

index 4674b69cea107b7895200b7857cf66dcbe401b54..b578e7ac3c35b9dc58802d82561ef41414f6ccf6 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

@@ -29,6 +29,7 @@

#include "core/HTMLNames.h"

#include "core/dom/Document.h"

#include "core/dom/ElementTraversal.h"

+#include "core/dom/NodeComputedStyle.h"

#include "core/dom/Range.h"

#include "core/dom/Text.h"

#include "core/dom/shadow/ShadowRoot.h"

@@ -764,7 +765,7 @@ bool isEnclosingBlock(const Node* node)

bool isInline(const Node* node)

{

- return node && node->layoutObject() && node->layoutObject()->isInline();

+ return node && node->computedStyle()->display() == INLINE;

}

// TODO(yosin) Deploy this in all of the places where |enclosingBlockFlow()| and