Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2105653002: Delete content::ServiceRegistry. (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, qsr+mojo_chromium.org, serviceworker-reviews, tzik, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ew
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete content::ServiceRegistry. R=rockot@chromium.org http://crbug.com/623393 Committed: https://crrev.com/7e875bc7ef1294d5be12965656aef3ac651d2622 Cr-Commit-Position: refs/heads/master@{#402839}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -335 lines) Patch
M content/browser/android/service_registry_android_impl.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/service_registry_android_impl.cc View 1 2 3 4 5 4 chunks +6 lines, -26 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/mojo/service_registry_impl.h View 1 chunk +0 lines, -77 lines 0 comments Download
D content/common/mojo/service_registry_impl.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M content/content_common.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M content/public/browser/android/service_registry_android.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/common/service_registry.h View 1 chunk +0 lines, -104 lines 0 comments Download
M content/renderer/mojo/interface_provider_js_wrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2106693002 Patch 60001

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-06-28 19:04:59 UTC) #1
Ken Rockot(use gerrit already)
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm ...
4 years, 5 months ago (2016-06-29 14:41:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105653002/100001
4 years, 5 months ago (2016-06-29 15:11:48 UTC) #4
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-06-29 16:48:19 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 16:51:23 UTC) #7
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/7e875bc7ef1294d5be12965656aef3ac651d2622
Cr-Commit-Position: refs/heads/master@{#402839}

Powered by Google App Engine
This is Rietveld 408576698