Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2105643002: Fix a regression caused by the background fullscreen handling code. (Closed)

Created:
4 years, 5 months ago by ananta
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix a regression caused by the background fullscreen handling code. Merging to M52 For context please refer to this patch https://codereview.chromium.org/1707233002 If a background fullscreen window's size changes again due to a minimize operation, we do inform the delegate about the size change. However during an activation gain if the background_fullscreen_hack_ flag is set we don't inform the delegate about the restored size (fullscreen) which leads to this bug Fix is to inform the delegate if the sent_window_size_changing_ flag is set in this case. BUG=613461 Review-Url: https://codereview.chromium.org/2007513004 Cr-Commit-Position: refs/heads/master@{#395666} (cherry picked from commit bda15a4588989436424bc74b05d6aad9c44b41df) Committed: https://chromium.googlesource.com/chromium/src/+/97690fc7759349821e04633c8b48542b54d6ba34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
ananta
4 years, 5 months ago (2016-06-28 03:34:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97690fc7759349821e04633c8b48542b54d6ba34 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698