Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2007513004: Fix a regression caused by the background fullscreen handling code. (Closed)

Created:
4 years, 7 months ago by ananta
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a regression caused by the background fullscreen handling code. For context please refer to this patch https://codereview.chromium.org/1707233002 If a background fullscreen window's size changes again due to a minimize operation, we do inform the delegate about the size change. However during an activation gain if the background_fullscreen_hack_ flag is set we don't inform the delegate about the restored size (fullscreen) which leads to this bug Fix is to inform the delegate if the sent_window_size_changing_ flag is set in this case. BUG=613461 Committed: https://crrev.com/bda15a4588989436424bc74b05d6aad9c44b41df Cr-Commit-Position: refs/heads/master@{#395666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ananta
4 years, 7 months ago (2016-05-23 22:22:07 UTC) #2
sky
LGTM
4 years, 7 months ago (2016-05-23 23:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007513004/1
4 years, 7 months ago (2016-05-24 19:03:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 19:08:44 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 19:10:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bda15a4588989436424bc74b05d6aad9c44b41df
Cr-Commit-Position: refs/heads/master@{#395666}

Powered by Google App Engine
This is Rietveld 408576698