Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2105513002: Use split_static_library in GN build. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@split_list
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use split_static_library in GN build. This is a new function of GN that allows us to automatically split large static libraries on Windows where the size becomes too large. BUG= Committed: https://crrev.com/f760b440babafea496f1a13aef7b984ba85a0df6 Cr-Commit-Position: refs/heads/master@{#402883}

Patch Set 1 #

Total comments: 1

Patch Set 2 : typo #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -9 lines) Patch
M build/config/BUILDCONFIG.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
A build/split_static_library.gni View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
brucedawson
lgtm with one spelling nit. https://codereview.chromium.org/2105513002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/2105513002/diff/1/build/config/BUILDCONFIG.gn#newcode606 build/config/BUILDCONFIG.gn:606: # be preactically implemented ...
4 years, 5 months ago (2016-06-28 20:31:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105513002/20001
4 years, 5 months ago (2016-06-29 06:02:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/252191)
4 years, 5 months ago (2016-06-29 08:58:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105513002/20001
4 years, 5 months ago (2016-06-29 17:31:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/252471)
4 years, 5 months ago (2016-06-29 17:45:22 UTC) #11
brettw
merge
4 years, 5 months ago (2016-06-29 17:46:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105513002/40001
4 years, 5 months ago (2016-06-29 17:48:21 UTC) #15
Robert Sesek
Is the same change going to be made to //chrome/browser/ui? (C.f. https://crbug.com/618797)
4 years, 5 months ago (2016-06-29 18:47:39 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 18:57:46 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 18:58:05 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:01:14 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f760b440babafea496f1a13aef7b984ba85a0df6
Cr-Commit-Position: refs/heads/master@{#402883}

Powered by Google App Engine
This is Rietveld 408576698