Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2987)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index c5c1ab9d5399cebc5dc9cc03af493b84944e3fab..6131dac683880a21a7586b2f2f400d9f07d6cde0 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4042,8 +4042,11 @@ void RenderFrameImpl::willSendRequest(
provider_id = provider->provider_id();
// Explicitly set the SkipServiceWorker flag here if the renderer process
// hasn't received SetControllerServiceWorker message.
- if (!provider->IsControlledByServiceWorker())
- request.setSkipServiceWorker(true);
+ if (!provider->IsControlledByServiceWorker() &&
+ request.skipServiceWorker() !=
+ blink::WebURLRequest::SkipServiceWorker::All)
+ request.setSkipServiceWorker(
+ blink::WebURLRequest::SkipServiceWorker::Controlling);
}
WebFrame* parent = frame->parent();
@@ -5844,7 +5847,8 @@ void RenderFrameImpl::BeginNavigation(blink::WebURLRequest* request,
BeginNavigationParams(GetWebURLRequestHeaders(*request),
GetLoadFlagsForWebURLRequest(*request),
request->hasUserGesture(),
- request->skipServiceWorker(),
+ request->skipServiceWorker() !=
+ blink::WebURLRequest::SkipServiceWorker::None,
GetRequestContextTypeForWebURLRequest(*request))));
}

Powered by Google App Engine
This is Rietveld 408576698