Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 2105433002: Add support for draws in vulkan read and write pixels (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@unitTests
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add support for draws in vulkan read and write pixels GL has a lot more optimizations checks here to make sure we do the most effecient and correct draw here, but for now as long as the features are support we just do basic draws for both reads and writes when we need certain conversions. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2105433002 Committed: https://skia.googlesource.com/skia/+/4583ec51d9ddc830eeb854db068235be96ce59c4

Patch Set 1 #

Patch Set 2 : Remove debug in test #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 2 4 chunks +42 lines, -18 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
egdaniel
Next part in getting unit tests working
4 years, 5 months ago (2016-06-27 17:25:40 UTC) #3
bsalomon
lgtm
4 years, 5 months ago (2016-06-27 17:59:26 UTC) #4
jvanverth1
https://codereview.chromium.org/2105433002/diff/20001/src/gpu/vk/GrVkGpu.cpp File src/gpu/vk/GrVkGpu.cpp (right): https://codereview.chromium.org/2105433002/diff/20001/src/gpu/vk/GrVkGpu.cpp#newcode266 src/gpu/vk/GrVkGpu.cpp:266: // to srcConfig, though that may be modified if ...
4 years, 5 months ago (2016-06-27 18:37:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105433002/40001
4 years, 5 months ago (2016-06-27 19:38:04 UTC) #8
egdaniel
https://codereview.chromium.org/2105433002/diff/20001/src/gpu/vk/GrVkGpu.cpp File src/gpu/vk/GrVkGpu.cpp (right): https://codereview.chromium.org/2105433002/diff/20001/src/gpu/vk/GrVkGpu.cpp#newcode266 src/gpu/vk/GrVkGpu.cpp:266: // to srcConfig, though that may be modified if ...
4 years, 5 months ago (2016-06-27 19:50:56 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 19:57:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4583ec51d9ddc830eeb854db068235be96ce59c4

Powered by Google App Engine
This is Rietveld 408576698