Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2098933002: Fix check for maxVertexAttributes in GrVkPipeline (Closed)

Created:
4 years, 5 months ago by egdaniel
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove old code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/gpu/vk/GrVkPipeline.cpp View 1 3 chunks +5 lines, -8 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 5 months ago (2016-06-24 20:56:45 UTC) #3
bsalomon
lgtm
4 years, 5 months ago (2016-06-24 21:02:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098933002/20001
4 years, 5 months ago (2016-06-27 13:58:37 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 14:15:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b05df0ff261d7819da55509df03fb4525af49b40

Powered by Google App Engine
This is Rietveld 408576698